From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from smtprelay01.ispgateway.de ([80.67.31.28])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <bernhard@bwalle.de>) id 1SGu2g-0001qs-OI
	for ptxdist@pengutronix.de; Sun, 08 Apr 2012 17:28:39 +0200
Received: from [78.47.165.117] (helo=regiomontanus.bwalle.de)
	by smtprelay01.ispgateway.de with esmtpsa (TLSv1:AES128-SHA:128)
	(Exim 4.68) (envelope-from <bernhard@bwalle.de>) id 1SGu2g-0000Ds-D2
	for ptxdist@pengutronix.de; Sun, 08 Apr 2012 17:28:38 +0200
Date: Sun, 8 Apr 2012 17:28:36 +0200
From: Bernhard Walle <bernhard@bwalle.de>
Message-ID: <20120408152836.GB13618@regiomontanus.bwalle.de>
References: <20120402203051.GD28453@pengutronix.de>
	<1333528952-2321-1-git-send-email-bernhard@bwalle.de>
	<20120408081515.GG13585@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20120408081515.GG13585@pengutronix.de>
Subject: Re: [ptxdist] [PATCH v3] rules: Add fbterm
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

* Michael Olbrich <m.olbrich@pengutronix.de> [2012-04-08 10:15]:
> 
> This is wrong. Now the whole package is only built on x86
> 
> PACKAGES-$(PTXCONF_FBTERM) += fbterm

Of course, that's right.

> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> 
> ifndef PTXCONF_ARCH_X86
> undefine PTXCONF_FBTERM_VESA
> endif

That yields me to the question if it wouldn't be better to omit that
check at all. If we can't get Kconfig right, what gives us the check?
It disables VESA support even when enabled where it's not available, but
that's the same as configure does automatically.

But during testing, I discovered another problem: If the option is
selected, libx86 is built:

  PACKAGES-$(PTXCONF_ARCH_X86)-$(PTXCONF_LIBX86)

doesn't help here because the dependency is resolved by kconfig before
the makefiles get executed. Do you see a problem to solve that?

Otherwise I would either just omit that VESA option (I don't need it) or
leave it to the user to select libx86 when FBTERM_VESA is selected.



Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de