Re: [ptxdist] [PATCH 5/5] Add ices

[Juergen Beisert <jbe@pengutronix.de>]

HI Michael,

Michael Olbrich wrote:
> [...]
> > diff --git a/rules/ices.in b/rules/ices.in
> > new file mode 100644
> > index 0000000..966fe6c
> > --- /dev/null
> > +++ b/rules/ices.in
> > @@ -0,0 +1,33 @@
> > +## SECTION=applications
> > +
> > +menuconfig ICES
> > +	tristate
> > +	prompt "ices                          "
> > +	select LIBVORBIS if ICES_VORBIS
> > +	select LIBXML2
> > +	select PYTHON if ICES_PYTHON
> > +	select LAME if ICES_LAME
>
> please indent.

????????

> [...]
> > diff --git a/rules/ices.make b/rules/ices.make
> > new file mode 100644
> > index 0000000..a5687ae
> > --- /dev/null
> > +++ b/rules/ices.make
> > @@ -0,0 +1,71 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2012 by Juergen Beisert <jbe@pengutronix.de>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license
> > conditions +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_ICES) += ices
> > +
> > +#
> > +# Paths and names
> > +#
> > +ICES_VERSION	:= 0.4
>
> Any reason for this version? I see 2.0.1, or is that something else?

From the website at "http://icecast.org/ices.php":

"Ices comes in two flavors, the 0.x flavor which supports sending an MP3 
stream to an icecast server, and the 2.x flavor which supports sending an Ogg 
Vorbis stream to an icecast server."

I'm not sure if this comment is still valid, as also the 0.4 revision has an 
option to enable Vorbis. But I need the MP3 feature, so I have decided to use 
the 0.4 revision.

> [...]
> > +	@$(call install_alternative, ices, 0, 0, 0644, /etc/ices.conf)
> > +ifdef PTXCONF_ICES_PYTHON
> > +	@$(call install_copy, ices, 0, 0, 0755, /etc/modules)
> > +	@$(call install_copy, ices, 0, 0, 0755, -, /etc/modules/ices.py.dist)
>
> This is not good. It clashes with /etc/modules for kernel modules.

Ups, you are right. Didn't noticed it.

I will send a new patch series.

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de