From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1SGSu8-0001r5-4q for ptxdist@pengutronix.de; Sat, 07 Apr 2012 12:30:00 +0200 Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1SGSu8-0003ds-3Y for ptxdist@pengutronix.de; Sat, 07 Apr 2012 12:30:00 +0200 Date: Sat, 7 Apr 2012 12:30:00 +0200 From: Michael Olbrich Message-ID: <20120407103000.GA13585@pengutronix.de> References: <1333716320-7923-1-git-send-email-jbe@pengutronix.de> <1333716320-7923-6-git-send-email-jbe@pengutronix.de> <20120406200113.GC28453@pengutronix.de> <201204071112.29462.jbe@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201204071112.29462.jbe@pengutronix.de> Subject: Re: [ptxdist] [PATCH 5/5] Add ices Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Sat, Apr 07, 2012 at 11:12:29AM +0200, Juergen Beisert wrote: > HI Michael, > > Michael Olbrich wrote: > > [...] > > > diff --git a/rules/ices.in b/rules/ices.in > > > new file mode 100644 > > > index 0000000..966fe6c > > > --- /dev/null > > > +++ b/rules/ices.in > > > @@ -0,0 +1,33 @@ > > > +## SECTION=applications > > > + > > > +menuconfig ICES > > > + tristate > > > + prompt "ices " > > > + select LIBVORBIS if ICES_VORBIS > > > + select LIBXML2 > > > + select PYTHON if ICES_PYTHON > > > + select LAME if ICES_LAME > > > > please indent. > > ???????? I meant the ifs: select LIBVORBIS if ICES_VORBIS [...] The same for some of the other patches I think. > > [...] > > > diff --git a/rules/ices.make b/rules/ices.make > > > new file mode 100644 > > > index 0000000..a5687ae > > > --- /dev/null > > > +++ b/rules/ices.make > > > @@ -0,0 +1,71 @@ > > > +# -*-makefile-*- > > > +# > > > +# Copyright (C) 2012 by Juergen Beisert > > > +# > > > +# See CREDITS for details about who has contributed to this project. > > > +# > > > +# For further information about the PTXdist project and license > > > conditions +# see the README file. > > > +# > > > + > > > +# > > > +# We provide this package > > > +# > > > +PACKAGES-$(PTXCONF_ICES) += ices > > > + > > > +# > > > +# Paths and names > > > +# > > > +ICES_VERSION := 0.4 > > > > Any reason for this version? I see 2.0.1, or is that something else? > > >From the website at "http://icecast.org/ices.php": > > "Ices comes in two flavors, the 0.x flavor which supports sending an MP3 > stream to an icecast server, and the 2.x flavor which supports sending an Ogg > Vorbis stream to an icecast server." > > I'm not sure if this comment is still valid, as also the 0.4 revision has an > option to enable Vorbis. But I need the MP3 feature, so I have decided to use > the 0.4 revision. ok. Michael > > [...] > > > + @$(call install_alternative, ices, 0, 0, 0644, /etc/ices.conf) > > > +ifdef PTXCONF_ICES_PYTHON > > > + @$(call install_copy, ices, 0, 0, 0755, /etc/modules) > > > + @$(call install_copy, ices, 0, 0, 0755, -, /etc/modules/ices.py.dist) > > > > This is not good. It clashes with /etc/modules for kernel modules. > > Ups, you are right. Didn't noticed it. > > I will send a new patch series. > > jbe > > -- > Pengutronix e.K. | Juergen Beisert | > Linux Solutions for Science and Industry | http://www.pengutronix.de/ | > > -- > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de