Re: [ptxdist] [PATCH 1/2] Add host-parted

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Mar 26, 2012 at 02:01:13PM +0200, Bernhard Walle wrote:
> Signed-off-by: Bernhard Walle <walle@corscience.de>
> ---
>  platforms/hosttools.in |    1 +
>  rules/host-parted.in   |    8 ++++++++
>  rules/host-parted.make |   38 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+)
>  create mode 100644 rules/host-parted.in
>  create mode 100644 rules/host-parted.make
> 
> diff --git a/platforms/hosttools.in b/platforms/hosttools.in
> index e9ce0fc..10d05e8 100644
> --- a/platforms/hosttools.in
> +++ b/platforms/hosttools.in
> @@ -18,6 +18,7 @@ source "rules/host-mkelfImage.in"
>  source "rules/host-mtd-utils.in"
>  source "rules/host-mtools.in"
>  source "rules/host-openssl.in"
> +source "rules/host-parted.in"
>  source "rules/host-squashfs-tools.in"
>  source "rules/host-u-boot-tools.in"
>  source "rules/host-util-linux-ng.in"
> diff --git a/rules/host-parted.in b/rules/host-parted.in
> new file mode 100644
> index 0000000..d150ffd
> --- /dev/null
> +++ b/rules/host-parted.in
> @@ -0,0 +1,8 @@
> +## SECTION=hosttools_noprompt
> +
> +config HOST_PARTED
> +	bool
> +	default ALLYES
> +	help
> +	  The well-known parted program

no need for help in noprompt options

> +
> diff --git a/rules/host-parted.make b/rules/host-parted.make
> new file mode 100644
> index 0000000..9655f5d
> --- /dev/null
> +++ b/rules/host-parted.make
> @@ -0,0 +1,38 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2006 by Robert Schwebel
> +#               2009 by Marc Kleine-Budde <mkl@pengutronix.de>

Shouldn't this be your copyright?

> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +HOST_PACKAGES-$(PTXCONF_HOST_PARTED) += host-parted
> +


> +#
> +# Paths and names
> +#
> +HOST_PARTED		= $(PARTED)
> +HOST_PARTED_DIR		= $(HOST_BUILDDIR)/$(HOST_PARTED)

remove

> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +HOST_PARTED_ENV 	:= $(HOST_ENV)

remove

> +
> +#
> +# autoconf
> +#
> +HOST_PARTED_AUTOCONF := $(HOST_AUTOCONF) \
> +	--disable-device-mapper \
> +	--disable-Werror

I'd like to see CONF_TOOL/CONF_OPT in new packages.

Take a look at e.g. rules/host-ncurses.make to see what's necessary.

> +
> +HOST_PARTED_INSTALL_OPT := install

Isn't that the default anyways?

> +
> +# vim: syntax=make
> -- 
> 1.7.9.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de