Re: [ptxdist] [PATCH 1/9 v2] [x86_64] Add x86_64 architecture strings.

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Mar 24, 2012 at 07:29:01PM +0100, Remy Bohmer wrote:
> 2012/3/23 Michael Olbrich <m.olbrich@pengutronix.de>:
> > I've seen the whole series, but I'm rather busy, and this requires a bit
> > more thinking. So it may take a while before we get everything in.
> >
> > On Mon, Mar 19, 2012 at 10:14:44PM +0100, Remy Bohmer wrote:
> >> The ARCH_X86_64 architecture is added as subtype of ARCH_X86 since it
> >> basically is the same architecture, and a mix of both architectures
> >> will be required to allow multilib support in a later commit.
> >>
> >> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> >> ---
> >>  v2: no changes since v1
> >>
> >>  platforms/architecture.in |   15 +++++++++++++--
> >>  1 files changed, 13 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/platforms/architecture.in b/platforms/architecture.in
> >> index ed36e8a..f00108e 100644
> >> --- a/platforms/architecture.in
> >> +++ b/platforms/architecture.in
> >> @@ -181,6 +181,16 @@ choice
> >>
> >>  endchoice
> >>
> >> +if ARCH_X86
> >> +#
> >> +# 32/64 bits platform
> >> +#
> >> +config ARCH_X86_64
> >> +     bool "64 bit architecture"
> >> +     help
> >> +       Select this option if you build for a 64 bit architecture.
> >> +
> >> +endif
> >
> > Have you considered adding ARCH_X86_32 as well (in a switch)? I think some
> > if our current "ifdef ARCH_X86" are really for 32bit only, so an option
> > would probably be useful.
> 
> I considered that but thought to look it like this: Assume the
> platform is 32 bit, unless specified otherwise.
> But maybe I have to look it at it more carefully. I drop it from the
> series, and will repost this patch later. First, finalize the rest of
> the series first.

You also need to do something with the "x86 optimization" choice. None of
the current choices support 64bit but there is hardware that could run with
either.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de