From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Sun, 25 Mar 2012 13:29:56 +0200 From: Michael Olbrich Message-ID: <20120325112956.GE27119@pengutronix.de> References: <1332191692-20833-1-git-send-email-linux@bohmer.net> <1332191692-20833-3-git-send-email-linux@bohmer.net> <20120323074226.GA20731@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] [PATCH 3/9 v2] [x86_64, multilib] Remove all hardcoded paths from glibc.make Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Cc: Marc Kleine-Budde On Sat, Mar 24, 2012 at 07:24:30PM +0100, Remy Bohmer wrote: > Hi, > > 2012/3/23 Michael Olbrich : > > On Mon, Mar 19, 2012 at 10:14:46PM +0100, Remy Bohmer wrote: > >> These hardcoded paths do not work for a multilib environment where > >> libraries are typically installed in /lib64 for x86-64 instead of /lib > >> All correct paths can be found by interrogating the compiler toolchain > >> for the location of these files. > > > > Can't you use $(CROSS_LIB_DIR) here? I'd like to avoid larger changes to > > install_copy_toolchain.sh. This depends a lot on the toolchain and is > > rather difficult to test. > > Are you sure you want this? Of course it can be done, but it feels > what somewhat redundant if we add an explicit path here. > After rebase on top of your gcc changes it is just a 1 line change. > Well, let's do the following: I first do the rebase, and see from > there how it looks. Adding CROSS_LIB_DIR can be done version 4 of the > patchset ;-) Keep it as it is for now. I think the paths are extra hints to find the libs. But this really depends on the toolchain. I don't know if this is still necessary. Marc: this is your code, can you comment on that? Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de