From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SAzJT-0002dT-EX
	for ptxdist@pengutronix.de; Fri, 23 Mar 2012 08:53:31 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SAzJT-0005So-Cr
	for ptxdist@pengutronix.de; Fri, 23 Mar 2012 08:53:31 +0100
Date: Fri, 23 Mar 2012 08:53:31 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120323075331.GB20731@pengutronix.de>
References: <1332191692-20833-1-git-send-email-linux@bohmer.net>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1332191692-20833-1-git-send-email-linux@bohmer.net>
Subject: Re: [ptxdist] [PATCH 1/9 v2] [x86_64] Add x86_64 architecture
 strings.
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

I've seen the whole series, but I'm rather busy, and this requires a bit
more thinking. So it may take a while before we get everything in.

On Mon, Mar 19, 2012 at 10:14:44PM +0100, Remy Bohmer wrote:
> The ARCH_X86_64 architecture is added as subtype of ARCH_X86 since it
> basically is the same architecture, and a mix of both architectures
> will be required to allow multilib support in a later commit.
> 
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> ---
>  v2: no changes since v1
> 
>  platforms/architecture.in |   15 +++++++++++++--
>  1 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/platforms/architecture.in b/platforms/architecture.in
> index ed36e8a..f00108e 100644
> --- a/platforms/architecture.in
> +++ b/platforms/architecture.in
> @@ -181,6 +181,16 @@ choice
>  
>  endchoice
>  
> +if ARCH_X86
> +#
> +# 32/64 bits platform
> +#
> +config ARCH_X86_64
> +	bool "64 bit architecture"
> +	help
> +	  Select this option if you build for a 64 bit architecture.
> +
> +endif

Have you considered adding ARCH_X86_32 as well (in a switch)? I think some
if our current "ifdef ARCH_X86" are really for 32bit only, so an option
would probably be useful.

Michael

>  
>  #
>  # endianess
> @@ -263,7 +273,7 @@ config HAS_MMU
>  config SIZEOF_LONG_DOUBLE
>  	string
>  	default "12" if ARCH_X86
> -#	default "16" if ARCH_X86_64
> +	default "16" if ARCH_X86_64
>  	default "8"
>  	# FIXME: add more values
>  
> @@ -277,7 +287,8 @@ config ARCH_STRING
>  	default "avr32"			if ARCH_AVR32
>  	default "alpha"			if ARCH_ALPHA
>  	default "blackfin"		if ARCH_BLACKFIN
> -	default "i386"			if ARCH_X86
> +	default "i386"			if ARCH_X86 && !ARCH_X86_64
> +	default "x86_64"		if ARCH_X86 && ARCH_X86_64
>  	default "i386"			if ARCH_MINGW
>  	default "m68k"			if ARCH_M68K
>  	default "ppc"			if ARCH_PPC
> -- 
> 1.7.5.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de