From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/9 v2] [x86_64] Add x86_64 architecture strings.
Date: Fri, 23 Mar 2012 08:53:31 +0100 [thread overview]
Message-ID: <20120323075331.GB20731@pengutronix.de> (raw)
In-Reply-To: <1332191692-20833-1-git-send-email-linux@bohmer.net>
Hi,
I've seen the whole series, but I'm rather busy, and this requires a bit
more thinking. So it may take a while before we get everything in.
On Mon, Mar 19, 2012 at 10:14:44PM +0100, Remy Bohmer wrote:
> The ARCH_X86_64 architecture is added as subtype of ARCH_X86 since it
> basically is the same architecture, and a mix of both architectures
> will be required to allow multilib support in a later commit.
>
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> ---
> v2: no changes since v1
>
> platforms/architecture.in | 15 +++++++++++++--
> 1 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/platforms/architecture.in b/platforms/architecture.in
> index ed36e8a..f00108e 100644
> --- a/platforms/architecture.in
> +++ b/platforms/architecture.in
> @@ -181,6 +181,16 @@ choice
>
> endchoice
>
> +if ARCH_X86
> +#
> +# 32/64 bits platform
> +#
> +config ARCH_X86_64
> + bool "64 bit architecture"
> + help
> + Select this option if you build for a 64 bit architecture.
> +
> +endif
Have you considered adding ARCH_X86_32 as well (in a switch)? I think some
if our current "ifdef ARCH_X86" are really for 32bit only, so an option
would probably be useful.
Michael
>
> #
> # endianess
> @@ -263,7 +273,7 @@ config HAS_MMU
> config SIZEOF_LONG_DOUBLE
> string
> default "12" if ARCH_X86
> -# default "16" if ARCH_X86_64
> + default "16" if ARCH_X86_64
> default "8"
> # FIXME: add more values
>
> @@ -277,7 +287,8 @@ config ARCH_STRING
> default "avr32" if ARCH_AVR32
> default "alpha" if ARCH_ALPHA
> default "blackfin" if ARCH_BLACKFIN
> - default "i386" if ARCH_X86
> + default "i386" if ARCH_X86 && !ARCH_X86_64
> + default "x86_64" if ARCH_X86 && ARCH_X86_64
> default "i386" if ARCH_MINGW
> default "m68k" if ARCH_M68K
> default "ppc" if ARCH_PPC
> --
> 1.7.5.4
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-03-23 7:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 21:14 Remy Bohmer
2012-03-19 21:14 ` [ptxdist] [PATCH 2/9 v2] [x86_64] libgcc need to be install in /lib64 instead of /lib Remy Bohmer
2012-03-19 21:14 ` [ptxdist] [PATCH 3/9 v2] [x86_64, multilib] Remove all hardcoded paths from glibc.make Remy Bohmer
2012-03-23 7:42 ` Michael Olbrich
2012-03-24 18:24 ` Remy Bohmer
2012-03-25 11:29 ` Michael Olbrich
2012-03-19 21:14 ` [ptxdist] [PATCH 4/9 v2] [x86_64, multilib] Make packages install their libraries at the right place Remy Bohmer
2012-03-24 11:04 ` Michael Olbrich
2012-03-24 11:06 ` Michael Olbrich
2012-03-19 21:14 ` [ptxdist] [PATCH 5/9 v2] [x86_64, multilib] Install Zlib " Remy Bohmer
2012-03-19 21:14 ` [ptxdist] [PATCH 6/9 v2] [x86_64, multilib] Install Ncurses " Remy Bohmer
2012-03-19 21:14 ` [ptxdist] [PATCH 7/9 v2] [x86_64, multilib] Install Util-linux-ng " Remy Bohmer
2012-03-19 21:14 ` [ptxdist] [PATCH 8/9 v2] [x86_64, multilib] Install Readline " Remy Bohmer
2012-03-19 21:14 ` [ptxdist] [PATCH 9/9 v2] [x86_64, multilib] Install Procps " Remy Bohmer
2012-03-23 7:53 ` Michael Olbrich [this message]
2012-03-24 18:29 ` [ptxdist] [PATCH 1/9 v2] [x86_64] Add x86_64 architecture strings Remy Bohmer
2012-03-26 8:50 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323075331.GB20731@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox