From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
From: Juergen Beisert <jbe@pengutronix.de>
Date: Thu, 22 Mar 2012 08:26:06 +0100
References: <201203202028.39620.jbe@pengutronix.de>
	<1332272207-80692-1-git-send-email-bernhard@bwalle.de>
	<20120321231859.GQ20481@pengutronix.de>
In-Reply-To: <20120321231859.GQ20481@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <201203220826.06135.jbe@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] flashbench: Fix error when flashbench is not
	selected
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>

Michael Olbrich wrote:
> On Tue, Mar 20, 2012 at 08:36:47PM +0100, Bernhard Walle wrote:
> > When flashbench is not selected in "ptxdist menuconfig", then
> > $(PTXCONF_FLASHBENCH_MAX_BUFSIZE) is undefined. In that case, the expr
> > call fails.
> >
> > Fix the problem by delaying the evaluation of FLASHBENCH_MAKE_OPT until
> > it's really needed, i.e. when flashbench has been selected.
> >
> > Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> > ---
> >  rules/flashbench.make |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rules/flashbench.make b/rules/flashbench.make
> > index fcb669e..0ef52d1 100644
> > --- a/rules/flashbench.make
> > +++ b/rules/flashbench.make
> > @@ -31,7 +31,7 @@ FLASHBENCH_LICENSE	:= GPL v2
> >
> >  FLASHBENCH_CONF_TOOL	:= NO
> >  FLASHBENCH_MAKE_ENV	:= $(CROSS_ENV)
> > -FLASHBENCH_MAKE_OPT	:= CC=$(CROSS_CC) \
>
> Please add a comment here. Otherwise it it not clear why this is needed.

Then we should discuss about comments in the changed files or in the change 
itself.
In the Linux kernel for example I see more and more complex comments in the 
change itself and nothing in the changed file. What is better? What is read 
more often? The change itself or the changed file?

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de