From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Date: Thu, 22 Mar 2012 08:40:41 +0100
From: Wolfram Sang <w.sang@pengutronix.de>
Message-ID: <20120322074041.GA9251@pengutronix.de>
References: <201203202028.39620.jbe@pengutronix.de>
	<1332272207-80692-1-git-send-email-bernhard@bwalle.de>
	<20120321231859.GQ20481@pengutronix.de>
	<201203220826.06135.jbe@pengutronix.de>
MIME-Version: 1.0
In-Reply-To: <201203220826.06135.jbe@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] flashbench: Fix error when flashbench is not
 selected
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============1767817537=="
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>


--===============1767817537==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G"
Content-Disposition: inline


--k1lZvvs/B4yU6o8G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > >  FLASHBENCH_CONF_TOOL	:=3D NO
> > >  FLASHBENCH_MAKE_ENV	:=3D $(CROSS_ENV)
> > > -FLASHBENCH_MAKE_OPT	:=3D CC=3D$(CROSS_CC) \
> >
> > Please add a comment here. Otherwise it it not clear why this is needed.
>=20
> Then we should discuss about comments in the changed files or in the chan=
ge=20
> itself.

In a comment, you describe why it is _done_ that way. In a commit message, =
you
describe why it needs to be _changed_ that way. Those two can be quite simi=
lar,
but often are not.

When in doubt, redundancy is your friend here :)

Regards,

   Wolfram

--=20
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

--k1lZvvs/B4yU6o8G
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAk9q13gACgkQD27XaX1/VRuKUgCgxO6wmA35ZG26gOcorxfjpLsp
fssAn1J/Y7/bOieq0Txpcbcw+s8SujBJ
=yV2d
-----END PGP SIGNATURE-----

--k1lZvvs/B4yU6o8G--


--===============1767817537==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-- 
ptxdist mailing list
ptxdist@pengutronix.de

--===============1767817537==--