From: Wolfram Sang <w.sang@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] flashbench: Fix error when flashbench is not selected
Date: Thu, 22 Mar 2012 08:40:41 +0100 [thread overview]
Message-ID: <20120322074041.GA9251@pengutronix.de> (raw)
In-Reply-To: <201203220826.06135.jbe@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 727 bytes --]
> > > FLASHBENCH_CONF_TOOL := NO
> > > FLASHBENCH_MAKE_ENV := $(CROSS_ENV)
> > > -FLASHBENCH_MAKE_OPT := CC=$(CROSS_CC) \
> >
> > Please add a comment here. Otherwise it it not clear why this is needed.
>
> Then we should discuss about comments in the changed files or in the change
> itself.
In a comment, you describe why it is _done_ that way. In a commit message, you
describe why it needs to be _changed_ that way. Those two can be quite similar,
but often are not.
When in doubt, redundancy is your friend here :)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-03-22 7:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 19:57 [ptxdist] [PATCH] [flashbench] Fix syntax error in case FLASHBENCH_MAX_BUFSIZE not defined Remy Bohmer
2012-03-20 8:43 ` Michael Olbrich
2012-03-20 8:47 ` Bernhard Walle
2012-03-20 9:09 ` Juergen Beisert
2012-03-20 19:02 ` Bernhard Walle
2012-03-20 19:28 ` Juergen Beisert
2012-03-20 19:35 ` Bernhard Walle
2012-03-20 19:44 ` Remy Bohmer
2012-03-20 19:36 ` [ptxdist] [PATCH] flashbench: Fix error when flashbench is not selected Bernhard Walle
2012-03-20 19:46 ` Remy Bohmer
2012-03-21 23:18 ` Michael Olbrich
2012-03-22 7:26 ` Juergen Beisert
2012-03-22 7:40 ` Wolfram Sang [this message]
2012-03-22 8:17 ` Bernhard Walle
2012-03-22 8:19 ` Bernhard Walle
2012-03-20 19:43 ` [ptxdist] [PATCH] [flashbench] Fix syntax error in case FLASHBENCH_MAX_BUFSIZE not defined Remy Bohmer
2012-03-20 8:57 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322074041.GA9251@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox