From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SAUnz-0001ZQ-KD
	for ptxdist@pengutronix.de; Thu, 22 Mar 2012 00:18:59 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1SAUnz-0002Tv-Ib
	for ptxdist@pengutronix.de; Thu, 22 Mar 2012 00:18:59 +0100
Date: Thu, 22 Mar 2012 00:18:59 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120321231859.GQ20481@pengutronix.de>
References: <201203202028.39620.jbe@pengutronix.de>
	<1332272207-80692-1-git-send-email-bernhard@bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1332272207-80692-1-git-send-email-bernhard@bwalle.de>
Subject: Re: [ptxdist] [PATCH] flashbench: Fix error when flashbench is not
 selected
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Tue, Mar 20, 2012 at 08:36:47PM +0100, Bernhard Walle wrote:
> When flashbench is not selected in "ptxdist menuconfig", then
> $(PTXCONF_FLASHBENCH_MAX_BUFSIZE) is undefined. In that case, the expr
> call fails.
> 
> Fix the problem by delaying the evaluation of FLASHBENCH_MAKE_OPT until
> it's really needed, i.e. when flashbench has been selected.
> 
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  rules/flashbench.make |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/flashbench.make b/rules/flashbench.make
> index fcb669e..0ef52d1 100644
> --- a/rules/flashbench.make
> +++ b/rules/flashbench.make
> @@ -31,7 +31,7 @@ FLASHBENCH_LICENSE	:= GPL v2
>  
>  FLASHBENCH_CONF_TOOL	:= NO
>  FLASHBENCH_MAKE_ENV	:= $(CROSS_ENV)
> -FLASHBENCH_MAKE_OPT	:= CC=$(CROSS_CC) \

Please add a comment here. Otherwise it it not clear why this is needed.

Michael

> +FLASHBENCH_MAKE_OPT	= CC=$(CROSS_CC) \
>  	EXTRA_CFLAGS=-DMAX_BUFSIZE=$(shell expr 1024 \* 1024 \* $(PTXCONF_FLASHBENCH_MAX_BUFSIZE))
>  
>  # ----------------------------------------------------------------------------
> -- 
> 1.7.9.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de