From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
From: Juergen Beisert <jbe@pengutronix.de>
Date: Tue, 20 Mar 2012 20:28:39 +0100
References: <1332187070-7282-1-git-send-email-linux@bohmer.net>
	<201203201009.43430.jbe@pengutronix.de>
	<20120320190252.GA22458@regiomontanus.bwalle.de>
In-Reply-To: <20120320190252.GA22458@regiomontanus.bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <201203202028.39620.jbe@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] [flashbench] Fix syntax error in case
	FLASHBENCH_MAX_BUFSIZE not defined
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: Bernhard Walle <bernhard@bwalle.de>
Cc: ptxdist@pengutronix.de

Hi Bernhard,

Bernhard Walle wrote:
> * Juergen Beisert <jbe@pengutronix.de> [2012-03-20 10:09]:
> > Just delay the evaluation of the expression to the point of time when it
> > is really required.
> >
> > diff --git a/rules/flashbench.make b/rules/flashbench.make
> > index fcb669e..0ef52d1 100644
> > --- a/rules/flashbench.make
> > +++ b/rules/flashbench.make
> > @@ -31,7 +31,7 @@ FLASHBENCH_LICENSE    := GPL v2
> >
> >  FLASHBENCH_CONF_TOOL   := NO
> >  FLASHBENCH_MAKE_ENV    := $(CROSS_ENV)
> > -FLASHBENCH_MAKE_OPT    := CC=$(CROSS_CC) \
> > +FLASHBENCH_MAKE_OPT    = CC=$(CROSS_CC) \
> >         EXTRA_CFLAGS=-DMAX_BUFSIZE=$(shell expr 1024 \* 1024 \* $(PTXCONF_FLASHBENCH_MAX_BUFSIZE))
>
> Did you try it out? It doesn't work here.

Yes I did.

[jb@isonoe]> ptxdist --version
2012.03.0-00045-gbea40f0

[jb@isonoe]> ptxdist go
expr: syntax error
make: Nothing to be done for `world'.

Now with the change above:

[jb@isonoe]> ptxdist go
make: Nothing to be done for `world'.

all tests with a disabled 'flashbench' in the menu.

Regards,
Juergen

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de