mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: Bernhard Walle <bernhard@bwalle.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] [flashbench] Fix syntax error in case FLASHBENCH_MAX_BUFSIZE not defined
Date: Tue, 20 Mar 2012 20:28:39 +0100	[thread overview]
Message-ID: <201203202028.39620.jbe@pengutronix.de> (raw)
In-Reply-To: <20120320190252.GA22458@regiomontanus.bwalle.de>

Hi Bernhard,

Bernhard Walle wrote:
> * Juergen Beisert <jbe@pengutronix.de> [2012-03-20 10:09]:
> > Just delay the evaluation of the expression to the point of time when it
> > is really required.
> >
> > diff --git a/rules/flashbench.make b/rules/flashbench.make
> > index fcb669e..0ef52d1 100644
> > --- a/rules/flashbench.make
> > +++ b/rules/flashbench.make
> > @@ -31,7 +31,7 @@ FLASHBENCH_LICENSE    := GPL v2
> >
> >  FLASHBENCH_CONF_TOOL   := NO
> >  FLASHBENCH_MAKE_ENV    := $(CROSS_ENV)
> > -FLASHBENCH_MAKE_OPT    := CC=$(CROSS_CC) \
> > +FLASHBENCH_MAKE_OPT    = CC=$(CROSS_CC) \
> >         EXTRA_CFLAGS=-DMAX_BUFSIZE=$(shell expr 1024 \* 1024 \* $(PTXCONF_FLASHBENCH_MAX_BUFSIZE))
>
> Did you try it out? It doesn't work here.

Yes I did.

[jb@isonoe]> ptxdist --version
2012.03.0-00045-gbea40f0

[jb@isonoe]> ptxdist go
expr: syntax error
make: Nothing to be done for `world'.

Now with the change above:

[jb@isonoe]> ptxdist go
make: Nothing to be done for `world'.

all tests with a disabled 'flashbench' in the menu.

Regards,
Juergen

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2012-03-20 19:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 19:57 Remy Bohmer
2012-03-20  8:43 ` Michael Olbrich
2012-03-20  8:47   ` Bernhard Walle
2012-03-20  9:09     ` Juergen Beisert
2012-03-20 19:02       ` Bernhard Walle
2012-03-20 19:28         ` Juergen Beisert [this message]
2012-03-20 19:35           ` Bernhard Walle
2012-03-20 19:44             ` Remy Bohmer
2012-03-20 19:36           ` [ptxdist] [PATCH] flashbench: Fix error when flashbench is not selected Bernhard Walle
2012-03-20 19:46             ` Remy Bohmer
2012-03-21 23:18             ` Michael Olbrich
2012-03-22  7:26               ` Juergen Beisert
2012-03-22  7:40                 ` Wolfram Sang
2012-03-22  8:17               ` Bernhard Walle
2012-03-22  8:19                 ` Bernhard Walle
2012-03-20 19:43       ` [ptxdist] [PATCH] [flashbench] Fix syntax error in case FLASHBENCH_MAX_BUFSIZE not defined Remy Bohmer
2012-03-20  8:57 ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203202028.39620.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=bernhard@bwalle.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox