From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1S9ufL-0004a8-Dl
	for ptxdist@pengutronix.de; Tue, 20 Mar 2012 09:43:39 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1S9ufL-0003YW-CW
	for ptxdist@pengutronix.de; Tue, 20 Mar 2012 09:43:39 +0100
Date: Tue, 20 Mar 2012 09:43:39 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120320084339.GJ20481@pengutronix.de>
References: <1332187070-7282-1-git-send-email-linux@bohmer.net>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1332187070-7282-1-git-send-email-linux@bohmer.net>
Subject: Re: [ptxdist] [PATCH] [flashbench] Fix syntax error in case
 FLASHBENCH_MAX_BUFSIZE not defined
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Mar 19, 2012 at 08:57:50PM +0100, Remy Bohmer wrote:
> This error occurs in case PTXCONF_FLASHBENCH_MAX_BUFSIZE is not defined:
> $ ptxdist get
> expr: syntax error
> make: Nothing to be done for `get'.
> 
> Change-Id: I1978d62b8781dbd5090b8a47b8fd8b944e6c79dc
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> ---
>  rules/flashbench.make |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/rules/flashbench.make b/rules/flashbench.make
> index fcb669e..b312979 100644
> --- a/rules/flashbench.make
> +++ b/rules/flashbench.make
> @@ -31,8 +31,14 @@ FLASHBENCH_LICENSE	:= GPL v2
>  
>  FLASHBENCH_CONF_TOOL	:= NO
>  FLASHBENCH_MAKE_ENV	:= $(CROSS_ENV)
> +
> +ifdef PTXCONF_FLASHBENCH_MAX_BUFSIZE
> +FLASHBENCH_MAX_BUFSIZE	:= $(PTXCONF_FLASHBENCH_MAX_BUFSIZE)
> +else
> +FLASHBENCH_MAX_BUFSIZE	:= 1
> +endif

I think we should report an error here:

ifndef PTXCONF_FLASHBENCH_MAX_BUFSIZE
$(error some error message here)
endif

Michael

>  FLASHBENCH_MAKE_OPT	:= CC=$(CROSS_CC) \
> -	EXTRA_CFLAGS=-DMAX_BUFSIZE=$(shell expr 1024 \* 1024 \* $(PTXCONF_FLASHBENCH_MAX_BUFSIZE))
> +	EXTRA_CFLAGS=-DMAX_BUFSIZE=$(shell expr 1024 \* 1024 \* $(FLASHBENCH_MAX_BUFSIZE))
>  
>  # ----------------------------------------------------------------------------
>  # Install
> -- 
> 1.7.5.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de