From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1S9ucE-0004HG-OC for ptxdist@pengutronix.de; Tue, 20 Mar 2012 09:40:26 +0100 Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1S9ucE-0003Xy-MZ for ptxdist@pengutronix.de; Tue, 20 Mar 2012 09:40:26 +0100 Date: Tue, 20 Mar 2012 09:40:26 +0100 From: Michael Olbrich Message-ID: <20120320084026.GI20481@pengutronix.de> References: <1332097818-23592-1-git-send-email-linux@bohmer.net> <1332097818-23592-5-git-send-email-linux@bohmer.net> <20120319161729.GG20481@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] [PATCH 4/9] [x86_64, multilib] Make packages install their libraries at the right place Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Mon, Mar 19, 2012 at 08:07:26PM +0100, Remy Bohmer wrote: > Hi, > = > 2012/3/19 Michael Olbrich : > >> +# Outputs 'lib' or 'lib64', derived from the ld-linux.so.2 from the c= ompiler toolchain > >> +CROSS_LIB_DIR =A0 =A0 =A0 =A0:=3D $(shell =A0 \ > >> + =A0 =A0 dl=3D"$$(echo 'int main(void){return 0;}' | \ > >> + =A0 =A0 ${CROSS_CC} ${CROSS_CPPFLAGS} ${CROSS_CFLAGS} -x c -o /dev/n= ull -v - 2>&1 | \ > >> + =A0 =A0 sed -n -e 's/.* -dynamic-linker \([^ ]*\).*/\1/p')"; \ > >> + =A0 =A0 lib_dir=3D"$${dl%%/ld-linux*}"; \ > >> + =A0 =A0 echo "$${lib_dir\#/}" \ > >> +) > > > > This is the same as ptxd_get_lib_dir, right? This function should be > > defined here: > = > This is indeed the same function, but for some reason the > ptxd_get_lib_dir was not available. > I will look at it again. > = > >> - =A0 =A0local file=3D"$(for dir in "${pkg_pkg_dir}/"{,usr/}lib; do > >> + =A0 =A0local file=3D"$(for dir in "${pkg_pkg_dir}/"{,usr/}lib{,64}; = do > > > > I don't like the explicit lib64 here. Next we'll get some debian like > > multilib toolchain and it's lib/x86_64-linux-gnu oor so. Can't we get t= hat > > from ptxd_get_lib_dir? > = > I think you are right and we can get it from ptxd_get_lib_dir, did not > thought about that before. Good idea! export -f ptxd_get_lib_dir directly after the function. Michael -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = ptxdist mailing list ptxdist@pengutronix.de