mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 4/9] [x86_64, multilib] Make packages install their libraries at the right place
Date: Tue, 20 Mar 2012 09:40:26 +0100	[thread overview]
Message-ID: <20120320084026.GI20481@pengutronix.de> (raw)
In-Reply-To: <CANqCtQ+xE_ib+WT_B=A=L+dUX0B_sW-v99X_UkdoYJ12xQtEUA@mail.gmail.com>

On Mon, Mar 19, 2012 at 08:07:26PM +0100, Remy Bohmer wrote:
> Hi,
> 
> 2012/3/19 Michael Olbrich <m.olbrich@pengutronix.de>:
> >> +# Outputs 'lib' or 'lib64', derived from the ld-linux.so.2 from the compiler toolchain
> >> +CROSS_LIB_DIR        := $(shell   \
> >> +     dl="$$(echo 'int main(void){return 0;}' | \
> >> +     ${CROSS_CC} ${CROSS_CPPFLAGS} ${CROSS_CFLAGS} -x c -o /dev/null -v - 2>&1 | \
> >> +     sed -n -e 's/.* -dynamic-linker \([^ ]*\).*/\1/p')"; \
> >> +     lib_dir="$${dl%%/ld-linux*}"; \
> >> +     echo "$${lib_dir\#/}" \
> >> +)
> >
> > This is the same as ptxd_get_lib_dir, right? This function should be
> > defined here:
> 
> This is indeed the same function, but for some reason the
> ptxd_get_lib_dir was not available.
> I will look at it again.
> 
> >> -    local file="$(for dir in "${pkg_pkg_dir}/"{,usr/}lib; do
> >> +    local file="$(for dir in "${pkg_pkg_dir}/"{,usr/}lib{,64}; do
> >
> > I don't like the explicit lib64 here. Next we'll get some debian like
> > multilib toolchain and it's lib/x86_64-linux-gnu oor so. Can't we get that
> > from ptxd_get_lib_dir?
> 
> I think you are right and we can get it from ptxd_get_lib_dir, did not
> thought about that before. Good idea!

export -f ptxd_get_lib_dir

directly after the function.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2012-03-20  8:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-18 19:10 [ptxdist] [PATCH 0/9] Add preliminary multilib support for x86_64 Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 1/9] [x86_64] Add x86_64 architecture strings Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 2/9] [x86_64] libgcc need to be install in /lib64 instead of /lib Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 3/9] [x86_64, multilib] Remove all hardcoded paths from glibc.make Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 4/9] [x86_64, multilib] Make packages install their libraries at the right place Remy Bohmer
2012-03-19 14:58   ` Remy Bohmer
2012-03-19 16:17   ` Michael Olbrich
2012-03-19 19:07     ` Remy Bohmer
2012-03-20  8:40       ` Michael Olbrich [this message]
2012-03-20  9:28         ` Remy Bohmer
2012-03-21  9:19           ` Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 5/9] [x86_64, multilib] Install Zlib " Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 6/9] [x86_64, multilib] Install Ncurses " Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 7/9] [x86_64, multilib] Install Util-linux-ng " Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 8/9] [x86_64, multilib] Install Readline " Remy Bohmer
2012-03-18 19:10 ` [ptxdist] [PATCH 9/9] [x86_64, multilib] Install Procps " Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120320084026.GI20481@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox