Re: [ptxdist] [PATCH 4/9] [x86_64, multilib] Make packages install their libraries at the right place

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Mar 19, 2012 at 08:07:26PM +0100, Remy Bohmer wrote:
> Hi,
> 
> 2012/3/19 Michael Olbrich <m.olbrich@pengutronix.de>:
> >> +# Outputs 'lib' or 'lib64', derived from the ld-linux.so.2 from the compiler toolchain
> >> +CROSS_LIB_DIR        := $(shell   \
> >> +     dl="$$(echo 'int main(void){return 0;}' | \
> >> +     ${CROSS_CC} ${CROSS_CPPFLAGS} ${CROSS_CFLAGS} -x c -o /dev/null -v - 2>&1 | \
> >> +     sed -n -e 's/.* -dynamic-linker \([^ ]*\).*/\1/p')"; \
> >> +     lib_dir="$${dl%%/ld-linux*}"; \
> >> +     echo "$${lib_dir\#/}" \
> >> +)
> >
> > This is the same as ptxd_get_lib_dir, right? This function should be
> > defined here:
> 
> This is indeed the same function, but for some reason the
> ptxd_get_lib_dir was not available.
> I will look at it again.
> 
> >> -    local file="$(for dir in "${pkg_pkg_dir}/"{,usr/}lib; do
> >> +    local file="$(for dir in "${pkg_pkg_dir}/"{,usr/}lib{,64}; do
> >
> > I don't like the explicit lib64 here. Next we'll get some debian like
> > multilib toolchain and it's lib/x86_64-linux-gnu oor so. Can't we get that
> > from ptxd_get_lib_dir?
> 
> I think you are right and we can get it from ptxd_get_lib_dir, did not
> thought about that before. Good idea!

export -f ptxd_get_lib_dir

directly after the function.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de