From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1S7lfP-00061W-Qk
	for ptxdist@pengutronix.de; Wed, 14 Mar 2012 11:42:51 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1S7lfP-0006gw-PX
	for ptxdist@pengutronix.de; Wed, 14 Mar 2012 11:42:51 +0100
Date: Wed, 14 Mar 2012 11:42:51 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120314104251.GE20481@pengutronix.de>
References: <1331674338-1757-1-git-send-email-linux@bohmer.net>
	<1331674338-1757-3-git-send-email-linux@bohmer.net>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1331674338-1757-3-git-send-email-linux@bohmer.net>
Subject: Re: [ptxdist] [PATCH 3/5 v2] [busybox] Pass extra platform CFLAGS
 to busybox make
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Tue, Mar 13, 2012 at 10:32:16PM +0100, Remy Bohmer wrote:
> Busybox make is not properly called in case:
> * compiler name tuple does not match target tuple (as used in multilib
>  compilers, for example: i686-pc-linux-gnu-gcc can compile for
>  x86_64-unknown-linux-gnu targets. To solve this the 'SUBARCH' need to be
>  set)
> * CONFIG_EXTRA_CFLAGS need to e set to select the proper sysroot to
>  compile against in busybox
> * LDFLAGS to link against the proper sysroot.
> 
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> ---
>  v2: Reworked review comments from Michael Olbrich
> 
>  rules/busybox.make |   21 ++++++++++++---------
>  1 files changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/rules/busybox.make b/rules/busybox.make
> index 536aa80..45fd20f 100644
> --- a/rules/busybox.make
> +++ b/rules/busybox.make
> @@ -48,15 +48,18 @@ $(STATEDIR)/busybox.prepare:
>  	@$(call touch)
>  
>  BUSYBOX_MAKE_OPT := \
> -	ARCH=$(PTXCONF_ARCH_STRING) \
> -	CROSS_COMPILE=$(COMPILER_PREFIX) \
> -	CONFIG_EXTRA_CFLAGS="$(CROSS_CFLAGS)" \
> -	HOSTCC=$(HOSTCC) \
> -	SKIP_STRIP=y
> -
> -ifdef PTXCONF_BUSYBOX_RFKILL
> -BUSYBOX_MAKE_OPT += CFLAGS="-I$(KERNEL_HEADERS_INCLUDE_DIR)"
> -endif
> +       ARCH=$(PTXCONF_ARCH_STRING) \
> +       SUBARCH=$(PTXCONF_ARCH_STRING) \
> +       CROSS_COMPILE=$(COMPILER_PREFIX) \
> +       HOSTCC=$(HOSTCC)

Indent with on <tab> everywhere.

> +
> +BUSYBOX_MAKE_ENV := \
> +       $(CROSS_ENV) \
> +       CFLAGS="$(CROSS_CFLAGS) -I$(KERNEL_HEADERS_INCLUDE_DIR)"
> +       SKIP_STRIP=y

Looks like SKIP_STRIP=y must be in BUSYBOX_MAKE_OPT, or it's not used.

> +
> +BUSYBOX_INSTAL_ENV := \

install with 2 'L'

Michael

> +       $(BUSYBOX_MAKE_ENV)
>  
>  BUSYBOX_INSTALL_OPT := \
>  	$(BUSYBOX_MAKE_OPT) \
> -- 
> 1.7.5.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de