Re: [ptxdist] [PATCH 3/5] [busybox] Pass extra platform CFLAGS to busybox make

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Mar 13, 2012 at 01:46:26PM +0100, Remy Bohmer wrote:
> Hi,
> 
> 2012/3/13 Michael Olbrich <m.olbrich@pengutronix.de>:
> > On Mon, Mar 12, 2012 at 10:25:02PM +0100, Remy Bohmer wrote:
> >> Busybox make is not properly called in case:
> >> * compiler name tuple does not match target tuple (as used in multilib
> >>   compilers, for example: i686-pc-linux-gnu-gcc can compile for
> >>   x86_64-unknown-linux-gnu targets. To solve this the 'SUBARCH' need to be
> >>   set)
> >> * CONFIG_EXTRA_CFLAGS need to e set to select the proper sysroot to
> >>   compile against in busybox
> >> * LDFLAGS to link against the proper sysroot.
> >>
> >> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> >> ---
> >>  rules/busybox.make |    3 +++
> >>  1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/rules/busybox.make b/rules/busybox.make
> >> index 536aa80..42cb81c 100644
> >> --- a/rules/busybox.make
> >> +++ b/rules/busybox.make
> >> @@ -49,9 +49,12 @@ $(STATEDIR)/busybox.prepare:
> >>
> >>  BUSYBOX_MAKE_OPT := \
> >>       ARCH=$(PTXCONF_ARCH_STRING) \
> >> +     SUBARCH=$(PTXCONF_ARCH_STRING) \
> >>       CROSS_COMPILE=$(COMPILER_PREFIX) \
> >>       CONFIG_EXTRA_CFLAGS="$(CROSS_CFLAGS)" \
> >>       HOSTCC=$(HOSTCC) \
> >> +     CONFIG_EXTRA_CFLAGS="$(PTXCONF_TARGET_EXTRA_CFLAGS)" \
> >> +     LDFLAGS="$(PTXCONF_TARGET_EXTRA_LDFLAGS)" \
> >
> >        CONFIG_EXTRA_CFLAGS="$(CROSS_CPPFLAGS) $(CROSS_CFLAGS)" \
> >        $(CROSS_ENV_LDFLAGS) \
> 
> This results in:
> -----------------------
> target: busybox.prepare
> -----------------------
> 
> make: invalid option -- '6'
> make: invalid option -- '4'
> make: invalid option -- '/'
> make: invalid option -- '/'
> Usage: make [options] [target] ...
> Options:
> etc.
> 
> It seems I have to stick with the bare minimal options I can set
> here... Or any other ideas?

Don't set any flags in BUSYBOX_MAKE_OPT. From what I can tell, the current
busybox Makefile uses CFLAGS, CPPFLAGS and LDFLAGS from the environment.
Try something like this (untested):

BUSYBOX_MAKE_OPT := \
	ARCH=$(PTXCONF_ARCH_STRING) \
	SUBARCH=$(PTXCONF_ARCH_STRING) \
	CROSS_COMPILE=$(COMPILER_PREFIX) \
	HOSTCC=$(HOSTCC)

BUSYBOX_MAKE_ENV := \
	$(CROSS_ENV) \
	CFLAGS="$(CROSS_CFLAGS) -I$(KERNEL_HEADERS_INCLUDE_DIR)"
	SKIP_STRIP=y

BUSYBOX_INSTAL_ENV := \
	$(BUSYBOX_MAKE_ENV)


and remove the PTXCONF_BUSYBOX_RFKILL stuff. The extra "-I" unconditionally
does not hurt.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de