mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/5] [x86_64] Add some support for multilib detection in the toolchain
Date: Tue, 13 Mar 2012 10:56:23 +0100	[thread overview]
Message-ID: <20120313095623.GH29221@pengutronix.de> (raw)
In-Reply-To: <1331587504-16721-2-git-send-email-linux@bohmer.net>

On Mon, Mar 12, 2012 at 10:25:01PM +0100, Remy Bohmer wrote:
> For Sourcery Codebench toolchains the 'gcc -print-file-name' only returns
> the proper sysroot directory when the proper architecture flags are
> provided via '-m64 -march=' flags. These flags are provided via the
> ptxdist platformconfig PTXCONF_TARGET_EXTRA_CFLAGS setting.
> These flags therefore also need to be passed to GCC here.
> 
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
> ---
>  scripts/install_copy_toolchain.sh |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/install_copy_toolchain.sh b/scripts/install_copy_toolchain.sh
> index 8a67698..48d65d7 100755
> --- a/scripts/install_copy_toolchain.sh
> +++ b/scripts/install_copy_toolchain.sh
> @@ -50,12 +50,13 @@ ptxd_abs2rel() {
>  # out: $lib_path
>  #
>  ptxd_get_lib_path() {
> -    local lib lib_dir lib_path
> +    local lib lib_dir lib_path extra_cflags
>  
>      lib="${1}"
> +    extra_cflags=$(source ${PTXDIST_PLATFORMCONFIG} && echo "${PTXCONF_TARGET_EXTRA_CFLAGS}")

I think ptxd_get_ptxconf should work here. And I think you should use
PTXCONF_TARGET_EXTRA_CFLAGS and PTXCONF_TARGET_EXTRA_CPPFLAGS.

>  
>      # ask the compiler for the lib
> -    lib_path="$(${CC} -print-file-name=${lib})"
> +    lib_path="$(${CC} ${extra_cflags} -print-file-name=${lib})"
>      if test "${lib_path}" = "${lib}"; then
>  	echo "install_copy_toolchain_lib: ${lib} not found" >&2
>  	return 1
> @@ -77,9 +78,10 @@ ptxd_get_lib_path() {
>  #
>  ptxd_get_dl() {
>      local dl
> +    extra_cflags=$(source ${PTXDIST_PLATFORMCONFIG} && echo "${PTXCONF_TARGET_EXTRA_CFLAGS}")

dito.

Michael

>  
>      dl="$(echo 'int main(void){return 0;}' | \
> -    	${CC} -x c -o /dev/null -v - 2>&1 | \
> +	${CC} ${extra_cflags} -x c -o /dev/null -v - 2>&1 | \
>  	sed -n -e 's/.* -dynamic-linker \([^ ]*\).*/\1/p')"
>  
>      echo "${dl##*/}"
> -- 
> 1.7.5.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2012-03-13  9:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 21:25 [ptxdist] [PATCH 1/5] [rt-tests] Use CFLAGS specified by ptxdist platformconfig Remy Bohmer
2012-03-12 21:25 ` [ptxdist] [PATCH 2/5] [x86_64] Add some support for multilib detection in the toolchain Remy Bohmer
2012-03-13  9:56   ` Michael Olbrich [this message]
2012-03-13 10:23     ` Remy Bohmer
2012-03-12 21:25 ` [ptxdist] [PATCH 3/5] [busybox] Pass extra platform CFLAGS to busybox make Remy Bohmer
2012-03-13  9:59   ` Michael Olbrich
2012-03-13 10:26     ` Remy Bohmer
2012-03-13 12:46     ` Remy Bohmer
2012-03-13 13:06       ` Michael Olbrich
2012-03-13 21:31         ` Remy Bohmer
2012-03-12 21:25 ` [ptxdist] [PATCH 4/5] [x86_64, libc] on multilib do not put all dynamic linkers in /lib Remy Bohmer
2012-03-13 10:07   ` Michael Olbrich
2012-03-13 10:28     ` Remy Bohmer
2012-03-13 10:34     ` Remy Bohmer
2012-03-13 10:58       ` Michael Olbrich
2012-03-12 21:25 ` [ptxdist] [PATCH 5/5] [x86_64, libc] Link /usr/lib/libdl.so is not needed and wrong on x86_64 Remy Bohmer
2012-03-13  9:53 ` [ptxdist] [PATCH 1/5] [rt-tests] Use CFLAGS specified by ptxdist platformconfig Michael Olbrich
2012-03-13 10:21   ` Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313095623.GH29221@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox