From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1S7OQ0-0000uE-E4 for ptxdist@pengutronix.de; Tue, 13 Mar 2012 10:53:24 +0100 Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1S7OQ0-0008F0-D2 for ptxdist@pengutronix.de; Tue, 13 Mar 2012 10:53:24 +0100 Date: Tue, 13 Mar 2012 10:53:24 +0100 From: Michael Olbrich Message-ID: <20120313095324.GG29221@pengutronix.de> References: <1331587504-16721-1-git-send-email-linux@bohmer.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1331587504-16721-1-git-send-email-linux@bohmer.net> Subject: Re: [ptxdist] [PATCH 1/5] [rt-tests] Use CFLAGS specified by ptxdist platformconfig Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Mon, Mar 12, 2012 at 10:25:00PM +0100, Remy Bohmer wrote: > The platformconfig can specify some valuable global flags for each > package in the configuration to build, for example: > * CPU optimisations (-march= and friends) > * multilib toolchain selection between x86_64 and ia32 such as used for > the Sourcery Codebench compiler toolchains as specified here: > https://sourcery.mentor.com/sgpp/lite/ia32/portal/doc12648/getting-started.pdf > > Signed-off-by: Remy Bohmer > --- > patches/rt-tests-0.73/add-extra-cflags.patch | 23 +++++++++++++++++++++++ > patches/rt-tests-0.73/series | 1 + > rules/rt-tests.make | 1 + > 3 files changed, 25 insertions(+), 0 deletions(-) > create mode 100644 patches/rt-tests-0.73/add-extra-cflags.patch > > diff --git a/patches/rt-tests-0.73/add-extra-cflags.patch b/patches/rt-tests-0.73/add-extra-cflags.patch > new file mode 100644 > index 0000000..6809377 > --- /dev/null > +++ b/patches/rt-tests-0.73/add-extra-cflags.patch > @@ -0,0 +1,23 @@ > +CFLAGS are specified in environment as well > + > +If the environment already has specified CFLAGS we shall > +not overwrite them > + > +Signed-off-by: Remy Bohmer > +--- > + Makefile | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +Index: rt-tests-0.73/Makefile > +=================================================================== > +--- rt-tests-0.73.orig/Makefile > ++++ rt-tests-0.73/Makefile > +@@ -14,7 +14,7 @@ bindir ?= $(prefix)/bin > + mandir ?= $(prefix)/share/man > + srcdir ?= $(prefix)/src > + > +-CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include > ++CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include $(CXXFLAGS) This should be: CFLAGS = $(CPPFLAGS) -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include $(CFLAGS) CFLAGS is for C CXXFLAGS for C++ and CPPFLAGS in theory for the preprocessor and therefore often used to pass flags for both. And note the order. And you should probably set: LIBS = $(LDFLAGS) -lrt -lpthread The flags should come first here. Michael > + > + PYLIB := $(shell python -c 'import distutils.sysconfig; print distutils.sysconfig.get_python_lib()') > + > diff --git a/patches/rt-tests-0.73/series b/patches/rt-tests-0.73/series > index 74fbce0..caf1a74 100644 > --- a/patches/rt-tests-0.73/series > +++ b/patches/rt-tests-0.73/series > @@ -1 +1,2 @@ > fix_3_0_issue.diff > +add-extra-cflags.patch > diff --git a/rules/rt-tests.make b/rules/rt-tests.make > index 3bc6568..1880beb 100644 > --- a/rules/rt-tests.make > +++ b/rules/rt-tests.make > @@ -34,6 +34,7 @@ RT_TESTS_DIR := $(BUILDDIR)/$(RT_TESTS) > > RT_TESTS_CONF_TOOL := NO > RT_TESTS_MAKE_OPT := $(CROSS_ENV_CC) prefix=/usr > +RT_TESTS_MAKE_ENV := $(CROSS_ENV_FLAGS) > RT_TESTS_INSTALL_OPT := $(RT_TESTS_MAKE_OPT) install > > # ---------------------------------------------------------------------------- > -- > 1.7.5.4 > > > -- > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de