From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1S7OEH-0000BB-Hm
	for ptxdist@pengutronix.de; Tue, 13 Mar 2012 10:41:17 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1S7OEH-00086m-GE
	for ptxdist@pengutronix.de; Tue, 13 Mar 2012 10:41:17 +0100
Date: Tue, 13 Mar 2012 10:41:17 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120313094117.GE29221@pengutronix.de>
References: <1331561345-9386-1-git-send-email-bernhard@bwalle.de>
	<1331561345-9386-2-git-send-email-bernhard@bwalle.de>
	<20120313091215.GB29221@pengutronix.de>
	<20120313091812.GA27982@regiomontanus.bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20120313091812.GA27982@regiomontanus.bwalle.de>
Subject: Re: [ptxdist] [PATCH 2/3] mtd-utils.in: Add busybox dependencies
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Tue, Mar 13, 2012 at 10:18:12AM +0100, Bernhard Walle wrote:
> * Michael Olbrich <m.olbrich@pengutronix.de> [2012-03-13 10:12]:
> > On Mon, Mar 12, 2012 at 03:09:04PM +0100, bernhard@bwalle.de wrote:
> > > From: Bernhard Walle <walle@corscience.de>
> > > 
> > > Some tools that mtd-utils provide can be also provided by busybox. Add
> > > the dependencies here as done in other configuration files to prevent
> > > the user from misconfiguration.
> > > 
> > > Signed-off-by: Bernhard Walle <walle@corscience.de>
> > > ---
> > >  rules/mtd-utils.in |   32 ++++++++++++++++++++++++++++++++
> > >  1 file changed, 32 insertions(+)
> > > 
> > > diff --git a/rules/mtd-utils.in b/rules/mtd-utils.in
> > > index bc25ace..30ec133 100644
> > > --- a/rules/mtd-utils.in
> > > +++ b/rules/mtd-utils.in
> > > @@ -43,9 +43,13 @@ config MTD_UTILS_FLASH_ERASEALL
> > >  	bool
> > >  	prompt "flash_eraseall (deprecated)"
> > >  	select MTD_UTILS_FLASH_ERASE
> > > +	depends on !BUSYBOX_FLASH_ERASEALL
> > 
> > 	depends on !BUSYBOX_FLASH_ERASEALL || ALLYES
> > 
> > For all. Sorry, I missed that in the last review.
> 
> Only for that one in rules/mtd-utils.in or really for all such Busybox
> comments?

Not the comments, just the tool. This is for compile-time testing. With
ALLYES enabled we can build everything in with one ptxconfig.
rules/coreutils.in is a good example on how it should look like.

Michael


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de