From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/3] mtd-utils.in: Add busybox dependencies
Date: Tue, 13 Mar 2012 10:41:17 +0100 [thread overview]
Message-ID: <20120313094117.GE29221@pengutronix.de> (raw)
In-Reply-To: <20120313091812.GA27982@regiomontanus.bwalle.de>
On Tue, Mar 13, 2012 at 10:18:12AM +0100, Bernhard Walle wrote:
> * Michael Olbrich <m.olbrich@pengutronix.de> [2012-03-13 10:12]:
> > On Mon, Mar 12, 2012 at 03:09:04PM +0100, bernhard@bwalle.de wrote:
> > > From: Bernhard Walle <walle@corscience.de>
> > >
> > > Some tools that mtd-utils provide can be also provided by busybox. Add
> > > the dependencies here as done in other configuration files to prevent
> > > the user from misconfiguration.
> > >
> > > Signed-off-by: Bernhard Walle <walle@corscience.de>
> > > ---
> > > rules/mtd-utils.in | 32 ++++++++++++++++++++++++++++++++
> > > 1 file changed, 32 insertions(+)
> > >
> > > diff --git a/rules/mtd-utils.in b/rules/mtd-utils.in
> > > index bc25ace..30ec133 100644
> > > --- a/rules/mtd-utils.in
> > > +++ b/rules/mtd-utils.in
> > > @@ -43,9 +43,13 @@ config MTD_UTILS_FLASH_ERASEALL
> > > bool
> > > prompt "flash_eraseall (deprecated)"
> > > select MTD_UTILS_FLASH_ERASE
> > > + depends on !BUSYBOX_FLASH_ERASEALL
> >
> > depends on !BUSYBOX_FLASH_ERASEALL || ALLYES
> >
> > For all. Sorry, I missed that in the last review.
>
> Only for that one in rules/mtd-utils.in or really for all such Busybox
> comments?
Not the comments, just the tool. This is for compile-time testing. With
ALLYES enabled we can build everything in with one ptxconfig.
rules/coreutils.in is a good example on how it should look like.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-03-13 9:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 14:09 [ptxdist] [PATCH 1/3] Update mtd-utils to 1.4.9 bernhard
2012-03-12 14:09 ` [ptxdist] [PATCH 2/3] mtd-utils.in: Add busybox dependencies bernhard
2012-03-13 9:12 ` Michael Olbrich
2012-03-13 9:18 ` Bernhard Walle
2012-03-13 9:41 ` Michael Olbrich [this message]
2012-03-12 14:09 ` [ptxdist] [PATCH 3/3] procps.in: Unify wording of busybox comments bernhard
2012-03-13 9:14 ` Michael Olbrich
2012-03-13 9:09 ` [ptxdist] [PATCH 1/3] Update mtd-utils to 1.4.9 Michael Olbrich
2012-03-13 12:02 ` Bernhard Walle
2012-03-13 12:00 ` [ptxdist] [PATCH] " bernhard
2012-03-13 13:31 ` Michael Olbrich
2012-03-13 13:34 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313094117.GE29221@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox