Re: [ptxdist] [PATCH] ptxdist: Check for GNU readlink

[Bernhard Walle <bernhard@bwalle.de>]

Hi Michael,

thanks again for the review.

* Michael Olbrich <m.olbrich@pengutronix.de> [2012-02-14 23:05]:
> > +# bash implementation of realpath / readlink -f
> > +#   arg1 - filename
> > +realpath()
> > +{
> > +	local fname oldfname
> > +
> 
> hmmm, scary.

What's wrong about 'local'?

> Another idea: Is the problem that "readlink -f" does not work or does
> "readlink" not exist at all? Any readlink implementations should work here
> for fname="$(readlink "${fname}")".

You're right. Even Apple adds a working readlink implementation. :)

> > +		if [ "$fname" = . ] ; then
> > +			fname="$(dirname $oldfname)"
> > +		elif echo $fname | grep -vq '^/' - ; then
> 
> 		elif [ "${fname}" -eq "${fname#/}" ]; then

-eq is only for numeric comparison, so it should be '=', right?

> 	( cd "$(dirname "${fname}")"
> 
> > +	fname=$(pwd -P)/$(basename $fname)
> 
> 	)

Assigning a variable in a subshell has no effect on the outer shell, has
it? But echo'ing directly here works.

A reworked version will follow.



Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de