[ptxdist] [PATCH] host-e2fsprogs: Build libraries as shared libraries

[ptxdist] [PATCH] host-e2fsprogs: Build libraries as shared libraries

[bernhard]

From: Bernhard Walle <walle@corscience.de>

If both the host-e2fsprogs and host-util-linux-ng are enabled (both
provide libuuid), I get following link error on a x86-64 Linux host when
host-e2fsprogs is built before host-util-linux-ng:

------------- 8< --------------

libtool: install: (cd /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/build-host/util-linux-2.19.1/shlibs/mount/src;
  /bin/sh /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/build-host/util-linux-2.19.1/libtool  --silent --tag CC
  --mode=relink gcc -std=gnu99 -fsigned-char -g -O2 -Wl,--version-script=../../../shlibs/mount/src/libmount.sym
  -version-info 2:0:1 -L/home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib
  -Wl,-rpath -Wl,/home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib
  -Wl,-rpath -Wl,/this/is/a/long/path/to/make/host/tools/relocateable/with/chrpath/when/using/dev/packages
  -o libmount.la -rpath /lib version.lo utils.lo test.lo init.lo cache.lo optstr.lo optmap.lo
  iter.lo lock.lo fs.lo tab.lo tab_parse.lo tab_update.lo context.lo context_mount.lo
  context_umount.lo at.lo mangle.lo canonicalize.lo strutils.lo env.lo
  ../../../shlibs/blkid/src/libblkid.la -inst-prefix-dir
  /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/packages/host-util-linux-2.19.1)
/usr/bin/ld: /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib/libblkid.a(cache.o):
  relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC

------------- >8 --------------

Building the libraries of the host-e2fsprogs package as shared libraries
instead of static libraries fixes that problem. Alternatively, it would
also work to build both as static libraries.

Signed-off-by: Bernhard Walle <walle@corscience.de>
---
 rules/host-e2fsprogs.make |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rules/host-e2fsprogs.make b/rules/host-e2fsprogs.make
index a32ff3c..3c905fe 100644
--- a/rules/host-e2fsprogs.make
+++ b/rules/host-e2fsprogs.make
@@ -29,7 +29,7 @@ HOST_E2FSPROGS_ENV 	:= $(HOST_ENV)
 #
 # autoconf
 #
-HOST_E2FSPROGS_AUTOCONF := $(HOST_AUTOCONF)
+HOST_E2FSPROGS_AUTOCONF := $(HOST_AUTOCONF) --enable-elf-shlibs
 HOST_E2FSPROGS_INSTALL_OPT := install install-libs
 
 # vim: syntax=make
-- 
1.7.9.1


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] host-e2fsprogs: Build libraries as shared libraries

[Michael Olbrich]

On Thu, Feb 16, 2012 at 10:52:11AM +0100, bernhard@bwalle.de wrote:
> From: Bernhard Walle <walle@corscience.de>
> 
> If both the host-e2fsprogs and host-util-linux-ng are enabled (both
> provide libuuid), I get following link error on a x86-64 Linux host when
> host-e2fsprogs is built before host-util-linux-ng:
> 
> ------------- 8< --------------
> 
> libtool: install: (cd /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/build-host/util-linux-2.19.1/shlibs/mount/src;
>   /bin/sh /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/build-host/util-linux-2.19.1/libtool  --silent --tag CC
>   --mode=relink gcc -std=gnu99 -fsigned-char -g -O2 -Wl,--version-script=../../../shlibs/mount/src/libmount.sym
>   -version-info 2:0:1 -L/home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib
>   -Wl,-rpath -Wl,/home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib
>   -Wl,-rpath -Wl,/this/is/a/long/path/to/make/host/tools/relocateable/with/chrpath/when/using/dev/packages
>   -o libmount.la -rpath /lib version.lo utils.lo test.lo init.lo cache.lo optstr.lo optmap.lo
>   iter.lo lock.lo fs.lo tab.lo tab_parse.lo tab_update.lo context.lo context_mount.lo
>   context_umount.lo at.lo mangle.lo canonicalize.lo strutils.lo env.lo
>   ../../../shlibs/blkid/src/libblkid.la -inst-prefix-dir
>   /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/packages/host-util-linux-2.19.1)
> /usr/bin/ld: /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib/libblkid.a(cache.o):
>   relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
> 
> ------------- >8 --------------
> 
> Building the libraries of the host-e2fsprogs package as shared libraries
> instead of static libraries fixes that problem. Alternatively, it would
> also work to build both as static libraries.

Hmm, what about removing 'install-libs' instead? Afaik that was only needed
when host-e2fsprogs provided host-libuuid/host-libblkid

Michael

> Signed-off-by: Bernhard Walle <walle@corscience.de>
> ---
>  rules/host-e2fsprogs.make |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/rules/host-e2fsprogs.make b/rules/host-e2fsprogs.make
> index a32ff3c..3c905fe 100644
> --- a/rules/host-e2fsprogs.make
> +++ b/rules/host-e2fsprogs.make
> @@ -29,7 +29,7 @@ HOST_E2FSPROGS_ENV 	:= $(HOST_ENV)
>  #
>  # autoconf
>  #
> -HOST_E2FSPROGS_AUTOCONF := $(HOST_AUTOCONF)
> +HOST_E2FSPROGS_AUTOCONF := $(HOST_AUTOCONF) --enable-elf-shlibs
>  HOST_E2FSPROGS_INSTALL_OPT := install install-libs
>  
>  # vim: syntax=make
> -- 
> 1.7.9.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH] host-e2fsprogs: Build libraries as shared libraries

[bernhard]

From: Bernhard Walle <walle@corscience.de>

If both the host-e2fsprogs and host-util-linux-ng are enabled (both
provide libuuid), I get following link error on a x86-64 Linux host when
host-e2fsprogs is built before host-util-linux-ng:

------------- 8< --------------

libtool: install: (cd /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/build-host/util-linux-2.19.1/shlibs/mount/src;
  /bin/sh /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/build-host/util-linux-2.19.1/libtool  --silent --tag CC
  --mode=relink gcc -std=gnu99 -fsigned-char -g -O2 -Wl,--version-script=../../../shlibs/mount/src/libmount.sym
  -version-info 2:0:1 -L/home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib
  -Wl,-rpath -Wl,/home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib
  -Wl,-rpath -Wl,/this/is/a/long/path/to/make/host/tools/relocateable/with/chrpath/when/using/dev/packages
  -o libmount.la -rpath /lib version.lo utils.lo test.lo init.lo cache.lo optstr.lo optmap.lo
  iter.lo lock.lo fs.lo tab.lo tab_parse.lo tab_update.lo context.lo context_mount.lo
  context_umount.lo at.lo mangle.lo canonicalize.lo strutils.lo env.lo
  ../../../shlibs/blkid/src/libblkid.la -inst-prefix-dir
  /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/packages/host-util-linux-2.19.1)
/usr/bin/ld: /home/bwalle/devel/xxxx/linux_rootfs/platform-yyyy/sysroot-host/lib/libblkid.a(cache.o):
  relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC

------------- >8 --------------

The problem is fixed when the libraries of host-e2fsprogs are not
installed.

Signed-off-by: Bernhard Walle <walle@corscience.de>
---
 rules/host-e2fsprogs.make |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rules/host-e2fsprogs.make b/rules/host-e2fsprogs.make
index a32ff3c..156a4e0 100644
--- a/rules/host-e2fsprogs.make
+++ b/rules/host-e2fsprogs.make
@@ -30,7 +30,7 @@ HOST_E2FSPROGS_ENV 	:= $(HOST_ENV)
 # autoconf
 #
 HOST_E2FSPROGS_AUTOCONF := $(HOST_AUTOCONF)
-HOST_E2FSPROGS_INSTALL_OPT := install install-libs
+HOST_E2FSPROGS_INSTALL_OPT := install
 
 # vim: syntax=make
 
-- 
1.7.9.1


-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH] generic/os-release: Quote ANSI_COLOR

[bernhard]

From: Bernhard Walle <walle@corscience.de>

To be able to source /etc/os-release in a script to read the variables,
quote the assignment of "1;34" to ANSI_COLOR.

Signed-off-by: Bernhard Walle <walle@corscience.de>
---
 generic/etc/os-release |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/generic/etc/os-release b/generic/etc/os-release
index bc77031..523c561 100644
--- a/generic/etc/os-release
+++ b/generic/etc/os-release
@@ -3,7 +3,7 @@ VERSION="@PTXDIST_VERSION@"
 ID=ptxdist
 VERSION_ID="@PTXDIST_VERSION@"
 PRETTY_NAME="PTXdist / @VENDOR@-@PROJECT@"
-ANSI_COLOR=1;34
+ANSI_COLOR="1;34"
 
 PTXDIST_VERSION="@PTXDIST_VERSION@"
 PTXDIST_BSP_VENDOR="@VENDOR@"
-- 
1.7.9.2


-- 
ptxdist mailing list
ptxdist@pengutronix.de