mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2] image_squashfs: Add possibility for LZO compression
Date: Wed, 1 Feb 2012 17:51:17 +0100	[thread overview]
Message-ID: <20120201165117.GL32382@pengutronix.de> (raw)
In-Reply-To: <1327937861-32188-1-git-send-email-alexander.stein@systec-electronic.com>

On Mon, Jan 30, 2012 at 04:37:41PM +0100, Alexander Stein wrote:
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> Changes in v2:
> * Add proposed changes from Michael

Tnx. Applied.

Michael

> 
>  platforms/image_squashfs.in    |   28 ++++++++++++++++++++++++++++
>  rules/post/image_squashfs.make |    1 +
>  2 files changed, 29 insertions(+), 0 deletions(-)
> 
> diff --git a/platforms/image_squashfs.in b/platforms/image_squashfs.in
> index 0d652d9..70bb140 100644
> --- a/platforms/image_squashfs.in
> +++ b/platforms/image_squashfs.in
> @@ -37,6 +37,34 @@ choice
>  
>  endchoice
>  
> +choice
> +	prompt "squashfs compression mode"
> +	depends on HOST_SQUASHFS_TOOLS_V4X
> +	help
> +	  Select your prefered compression mode. GZIP seems to have a better
> +	  compression rate while LZO is faster then GZIP. This will make a difference
> +	  in mount time of your filesystem depending on your hardware configuration.
> +
> +	config HOST_SQUASHFS_COMPRESSION_MODE_GZIP
> +	bool "gzip"
> +	help
> +	  Select your prefered compression mode. GZIP seems to have a better
> +	  compression rate while LZO is faster then GZIP. This will make a difference
> +	  in mount time of your filesystem depending on your hardware configuration.
> +
> +	config HOST_SQUASHFS_COMPRESSION_MODE_LZO
> +	bool "lzo"
> +	help
> +	  Select your prefered compression mode. GZIP seems to have a better
> +	  compression rate while LZO is faster then GZIP. This will make a difference
> +	  in mount time of your filesystem depending on your hardware configuration.
> +endchoice
> +
> +config HOST_SQUASHFS_COMPRESSION_MODE
> +        string
> +        default "gzip" if HOST_SQUASHFS_COMPRESSION_MODE_GZIP
> +        default "lzo" if HOST_SQUASHFS_COMPRESSION_MODE_LZO
> +
>  config IMAGE_SQUASHFS_BLOCK_SIZE
>  	string
>  	default "${PTXCONF_FLASH_BLOCKSIZE}"
> diff --git a/rules/post/image_squashfs.make b/rules/post/image_squashfs.make
> index 5462199..fdefadf 100644
> --- a/rules/post/image_squashfs.make
> +++ b/rules/post/image_squashfs.make
> @@ -12,6 +12,7 @@ SEL_ROOTFS-$(PTXCONF_IMAGE_SQUASHFS)	+= $(IMAGEDIR)/root.squashfs
>  
>  IMAGE_SQUASHFS_EXTRA_ARGS := \
>  	$(call ptx/ifdef, PTXCONF_HOST_SQUASHFS_TOOLS_V3X, $(call ptx/ifdef, PTXCONF_ENDIAN_BIG, -be, -le), ) \
> +	$(call ptx/ifdef, PTXCONF_HOST_SQUASHFS_TOOLS_V4X, -comp $(PTXCONF_HOST_SQUASHFS_COMPRESSION_MODE), ) \
>  	$(PTXCONF_IMAGE_SQUASHFS_EXTRA_ARGS)
>  
>  $(IMAGEDIR)/root.squashfs: $(STATEDIR)/image_working_dir $(STATEDIR)/host-squashfs-tools.install.post
> -- 
> 1.7.3.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2012-02-01 16:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 11:35 [ptxdist] [PATCH 1/2] host-squashfs-tools: Add LZO support Alexander Stein
2012-01-30 11:35 ` [ptxdist] [PATCH 2/2] image_squashfs: Add possibility for LZO compression Alexander Stein
2012-01-30 14:11   ` Michael Olbrich
2012-01-30 15:37     ` [ptxdist] [PATCH v2] " Alexander Stein
2012-02-01 16:51       ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120201165117.GL32382@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox