From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1RsVof-0004sZ-GS
	for ptxdist@pengutronix.de; Wed, 01 Feb 2012 09:45:21 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1RsVof-0007uJ-FM
	for ptxdist@pengutronix.de; Wed, 01 Feb 2012 09:45:21 +0100
Date: Wed, 1 Feb 2012 09:45:21 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120201084521.GF32382@pengutronix.de>
References: <1327864549-90478-1-git-send-email-bernhard@bwalle.de>
	<20120130140611.GD31245@pengutronix.de>
	<20120130184639.GA19699@regiomontanus.bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20120130184639.GA19699@regiomontanus.bwalle.de>
Subject: Re: [ptxdist] [PATCH] make 3.82: Don't rely on sorted wildcard
 expansion
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Jan 30, 2012 at 07:46:39PM +0100, Bernhard Walle wrote:
> * Michael Olbrich <m.olbrich@pengutronix.de> [2012-01-30 15:06]:
> > 
> > This is not correct. It will sort all post files and does not honor the
> > order of PTXDIST_PATH_POSTRULES. This should probably be something like
> > this (untested):
> > 
> > $(foreach dir, $(call reverse,$(subst :,$(space),$(PTXDIST_PATH_POSTRULES))), include (sort $(wildcard $(dir)/*.make)))
> 
> I'm not really a make guru like you. Your example doesn't work.
> Following works:
> 
> include $(foreach dir, $(call reverse,$(subst :,$(space),$(PTXDIST_PATH_POSTRULES))), $(sort $(wildcard $(dir)/*.make)))
> 
> Does that look correct in your eyes?

Yes, this is better. Don't forget PRERULES in the patch.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de