From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] make 3.82: Don't rely on sorted wildcard expansion
Date: Wed, 1 Feb 2012 09:45:21 +0100 [thread overview]
Message-ID: <20120201084521.GF32382@pengutronix.de> (raw)
In-Reply-To: <20120130184639.GA19699@regiomontanus.bwalle.de>
On Mon, Jan 30, 2012 at 07:46:39PM +0100, Bernhard Walle wrote:
> * Michael Olbrich <m.olbrich@pengutronix.de> [2012-01-30 15:06]:
> >
> > This is not correct. It will sort all post files and does not honor the
> > order of PTXDIST_PATH_POSTRULES. This should probably be something like
> > this (untested):
> >
> > $(foreach dir, $(call reverse,$(subst :,$(space),$(PTXDIST_PATH_POSTRULES))), include (sort $(wildcard $(dir)/*.make)))
>
> I'm not really a make guru like you. Your example doesn't work.
> Following works:
>
> include $(foreach dir, $(call reverse,$(subst :,$(space),$(PTXDIST_PATH_POSTRULES))), $(sort $(wildcard $(dir)/*.make)))
>
> Does that look correct in your eyes?
Yes, this is better. Don't forget PRERULES in the patch.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-02-01 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 19:15 Bernhard Walle
2012-01-30 14:06 ` Michael Olbrich
2012-01-30 18:46 ` Bernhard Walle
2012-02-01 8:45 ` Michael Olbrich [this message]
2012-02-02 20:23 ` Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201084521.GF32382@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox