From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1RsERN-0001az-01 for ptxdist@pengutronix.de; Tue, 31 Jan 2012 15:12:09 +0100 Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72) (envelope-from ) id 1RsERM-0003hb-VB for ptxdist@pengutronix.de; Tue, 31 Jan 2012 15:12:08 +0100 Date: Tue, 31 Jan 2012 15:12:08 +0100 From: Michael Olbrich Message-ID: <20120131141208.GA32382@pengutronix.de> References: <2236550.JcqvJ5vtdt@ws-stein> <20120104165957.GL21393@pengutronix.de> <1449371.MGWo599kFb@ws-stein> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1449371.MGWo599kFb@ws-stein> Subject: Re: [ptxdist] Detect if x86 target is 32 or 64bit? Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Tue, Jan 31, 2012 at 09:21:30AM +0100, Alexander Stein wrote: > On Wednesday 04 January 2012 17:59:57 Michael Olbrich wrote: > > On Wed, Jan 04, 2012 at 03:27:46PM +0100, Alexander Stein wrote: > > > how can I detect if a x86 target is 32 or 64bit? I'm working on a package > rule > > > for gnu-efi and elilo which need to know if it should generate ia32, > x86_64 > > > (or ia64) binaries. > > > I just know about PTXCONF_ARCH_X86 but this does not show what I want. > There > > > is also PTXCONF_KERNEL_ARCH_X86_64 for 64bit but this needs a linux kernel > > > configured. Any other ideas? > > > > This is not yet supported. You'll need to add ARCH_X86_64 and ARCH_IA64 to > > platforms/architecture.in and set the correct defaults for HAS_HARDFLOAT > > etc. > > Send patches :-) > > I doubt it's the best way to just add ARCH_X86_64 (and maybe ARCH_IA64). A lot > of rules files use "ifdef PTXCONF_ARCH_X86". So this has to be reworked to be > useable in X86_64, as most cases don't make a difference to 32 or 64 Bit. > Maybe it's better, to add a 64Bit entry in the optimization. Thoughts? I have no idea which way will be easier to implement. But I don't think adding to the optimization is the best. There will be places where you need to separate 32 vs 64 bit (e.g. SIZEOF_LONG_DOUBLE). So I guess you should start with a (ARCH_X86_32|ARCH_X86_64) choice and check if any "ifdef PTXCONF_ARCH_X86" need to be changed. If there are few/no uses of ARCH_X86 left then we can rename ARCH_X86_32 to ARCH_X86. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de