From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from smtprelay02.ispgateway.de ([80.67.31.36])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <bernhard@bwalle.de>) id 1RrwFW-0005hM-33
	for ptxdist@pengutronix.de; Mon, 30 Jan 2012 19:46:44 +0100
Received: from [78.47.165.117] (helo=regiomontanus.bwalle.de)
	by smtprelay02.ispgateway.de with esmtpsa (TLSv1:AES128-SHA:128)
	(Exim 4.68) (envelope-from <bernhard@bwalle.de>) id 1RrwFV-0007dR-Kb
	for ptxdist@pengutronix.de; Mon, 30 Jan 2012 19:46:41 +0100
Date: Mon, 30 Jan 2012 19:46:39 +0100
From: Bernhard Walle <bernhard@bwalle.de>
Message-ID: <20120130184639.GA19699@regiomontanus.bwalle.de>
References: <1327864549-90478-1-git-send-email-bernhard@bwalle.de>
	<20120130140611.GD31245@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20120130140611.GD31245@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] make 3.82: Don't rely on sorted wildcard
 expansion
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi Michael,

* Michael Olbrich <m.olbrich@pengutronix.de> [2012-01-30 15:06]:
> 
> This is not correct. It will sort all post files and does not honor the
> order of PTXDIST_PATH_POSTRULES. This should probably be something like
> this (untested):
> 
> $(foreach dir, $(call reverse,$(subst :,$(space),$(PTXDIST_PATH_POSTRULES))), include (sort $(wildcard $(dir)/*.make)))

I'm not really a make guru like you. Your example doesn't work.
Following works:

include $(foreach dir, $(call reverse,$(subst :,$(space),$(PTXDIST_PATH_POSTRULES))), $(sort $(wildcard $(dir)/*.make)))

Does that look correct in your eyes?


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de