From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Rpcuj-0003NO-VU
	for ptxdist@pengutronix.de; Tue, 24 Jan 2012 10:43:41 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Rpcuj-00083Y-US
	for ptxdist@pengutronix.de; Tue, 24 Jan 2012 10:43:41 +0100
Date: Tue, 24 Jan 2012 10:43:41 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120124094341.GM12400@pengutronix.de>
References: <1327232595-25378-1-git-send-email-bernhard@bwalle.de>
	<1327232595-25378-3-git-send-email-bernhard@bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1327232595-25378-3-git-send-email-bernhard@bwalle.de>
Subject: Re: [ptxdist] [PATCH 2/3] kernel: Use host-elf-h-compat
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Sun, Jan 22, 2012 at 12:43:14PM +0100, Bernhard Walle wrote:
> Add a dependency to the host tool and set the include flags properly.
> 
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  platforms/hosttools.in |    1 +
>  platforms/kernel.in    |    1 +
>  rules/kernel.make      |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/platforms/hosttools.in b/platforms/hosttools.in
> index 155b30b..0435545 100644
> --- a/platforms/hosttools.in
> +++ b/platforms/hosttools.in
> @@ -5,6 +5,7 @@ source "rules/host-cmake.in"
>  source "rules/host-cramfs.in"
>  source "rules/host-dosfstools.in"
>  source "rules/host-e2fsprogs.in"
> +source "rules/host-elf-h-compat.in"

this should be in the first patch, if at all (see my other mail).

>  source "rules/host-genext2fs.in"
>  source "rules/host-genpart.in"
>  source "rules/host-gettext.in"
> diff --git a/platforms/kernel.in b/platforms/kernel.in
> index b601284..4391e79 100644
> --- a/platforms/kernel.in
> +++ b/platforms/kernel.in
> @@ -2,6 +2,7 @@ menuconfig KERNEL
>  	bool
>  	default y
>  	select IMAGE_KERNEL
> +	select HOST_ELF_H_COMPAT
>  	select HOST_UMKIMAGE		if KERNEL_IMAGE_U
>  	select HOST_XZ			if KERNEL_XZ
>  	select HOST_LZOP		if KERNEL_LZOP
> diff --git a/rules/kernel.make b/rules/kernel.make
> index a445182..f125a69 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -47,6 +47,7 @@ KERNEL_ENV 	:= KCONFIG_NOTIMESTAMP=1
>  KERNEL_MAKEVARS := \
>  	$(PARALLELMFLAGS) \
>  	HOSTCC=$(HOSTCC) \
> +	HOSTCFLAGS=$(HOST_CPPFLAGS) $(HOST_CFLAGS) \

- add quotes
- This overwrites the defaults, so I'm not sure that's the right thing to
  do. Maybe use HOST_EXTRACFLAGS?
- HOST_CFLAGS is not used in ptxdist and should be empty.

So

	HOSTCFLAGS="$(HOST_CPPFLAGS)" \
or
	HOST_EXTRACFLAGS="$(HOST_CPPFLAGS)" \

Maybe there are some kernel developers here, that can comment on that?

Michael


>  	ARCH=$(PTXCONF_KERNEL_ARCH_STRING) \
>  	CROSS_COMPILE=$(KERNEL_CROSS_COMPILE) \
>  	\
> -- 
> 1.7.7.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de