Re: [ptxdist] [PATCH 1/3] Add host-elf-h-compat package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sun, Jan 22, 2012 at 12:43:13PM +0100, Bernhard Walle wrote:
> This package should provide <elf.h> on host operating systems that have
> no /usr/include/elf.h. The header is copied from glibc, modified a bit
> to remove Gnu dependencies and is sufficient to compile the Linux kernel
> and module-init-tools.
> 
> The package itself only checks if elf.h is present. If yes, it does
> nothing on "make install". If not, it installs its own copy of elf.h in
> "make install" to the include directory set in autoconf.

I like it in general, but I'm a bit concerned about maintaining the correct
dependencies.
How about this:

> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  rules/host-elf-h-compat.in   |    4 ++++
>  rules/host-elf-h-compat.make |   32 ++++++++++++++++++++++++++++++++
>  2 files changed, 36 insertions(+), 0 deletions(-)
>  create mode 100644 rules/host-elf-h-compat.in
>  create mode 100644 rules/host-elf-h-compat.make
> 
> diff --git a/rules/host-elf-h-compat.in b/rules/host-elf-h-compat.in
> new file mode 100644
> index 0000000..8a263ea
> --- /dev/null
> +++ b/rules/host-elf-h-compat.in
> @@ -0,0 +1,4 @@
> +## SECTION=hosttools_noprompt
> +
> +config HOST_ELF_H_COMPAT
> +	bool
	default y

> diff --git a/rules/host-elf-h-compat.make b/rules/host-elf-h-compat.make
> new file mode 100644
> index 0000000..7001344
> --- /dev/null
> +++ b/rules/host-elf-h-compat.make
> @@ -0,0 +1,32 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2012 by Bernhard Walle <bernhard@bwalle.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#

LAZY_PACKAGES-$(PTXCONF_HOST_ELF_H_COMPAT) += host-elf-h-compat

> +
> +#
> +# Paths and names
> +#
> +HOST_ELF_H_COMPAT_VERSION	:= 0.1
> +HOST_ELF_H_COMPAT_MD5          	:= dc45cdadcac50a42175f66ffed2d4375
> +HOST_ELF_H_COMPAT		:= elf-h-compat-$(HOST_ELF_H_COMPAT_VERSION)
> +HOST_ELF_H_COMPAT_SUFFIX	:= tar.bz2
> +HOST_ELF_H_COMPAT_URL	        := http://bwalle.de/programme//$(HOST_ELF_H_COMPAT).$(HOST_ELF_H_COMPAT_SUFFIX)
> +HOST_ELF_H_COMPAT_SOURCE	:= $(SRCDIR)/$(HOST_ELF_H_COMPAT).$(HOST_ELF_H_COMPAT_SUFFIX)
> +HOST_ELF_H_COMPAT_DIR	        := $(HOST_BUILDDIR)/$(HOST_ELF_H_COMPAT)

ifneq($(shell uname -s),Linux)
$(STATEDIR)/base.prepare: $(STATEDIR)host-elf-h-compat.install.post
endif

This way, it's built before any real packages on non-Linux hosts.

Michael

> +
> +#
> +# autoconf
> +#
> +HOST_ELF_H_COMPAT_CONF_TOOL	:= autoconf
> +
> +# vim: syntax=make
> -- 
> 1.7.7.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de