From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Rny5H-00022I-6r
	for ptxdist@pengutronix.de; Thu, 19 Jan 2012 20:55:43 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Rny5H-0001tp-5x
	for ptxdist@pengutronix.de; Thu, 19 Jan 2012 20:55:43 +0100
Date: Thu, 19 Jan 2012 20:55:43 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120119195543.GA4854@pengutronix.de>
References: <1326745825-61103-1-git-send-email-bernhard@bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1326745825-61103-1-git-send-email-bernhard@bwalle.de>
Subject: Re: [ptxdist] [PATCH] Fix usage of fakeroot on Darwin
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Jan 16, 2012 at 09:30:25PM +0100, Bernhard Walle wrote:
> The extension of shared libraries on Darwin is .dylib, not .so. While
> the fakeroot script itself (which is part of the fakeroot distribution)
> can handle Darwin, ptxdist calls 'fakeroot' with the '-l' parameter and
> directly provides the full path to the shared library which is
> pre-loaded.

Can you try removing '-l <lib>' instead. From looking at the fakeroot
source, it should work. We use it like that in other places already.

Michael

> This patch adds a simple check, explicitly checking for Darwin in the
> 'uname -s' output. Verified to fix the build on Mac OS 10.7 (Lion).
> 
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  rules/pre/Rules.make |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
> index c531a50..32c198b 100644
> --- a/rules/pre/Rules.make
> +++ b/rules/pre/Rules.make
> @@ -13,7 +13,14 @@ GNU_BUILD	:= $(shell $(SCRIPTSDIR)/autoconf/config.guess)
>  GNU_HOST	:= $(shell echo $(GNU_BUILD) | sed s/-[a-zA-Z0-9_]*-/-host-/)
>  
>  INSTALL		:= install
> -FAKEROOT	:= $(PTXDIST_SYSROOT_HOST)/bin/fakeroot -l $(PTXDIST_SYSROOT_HOST)/lib/libfakeroot.so
> +
> +ifeq ($(shell uname -s),Darwin)
> +SHLIB_SUFFIX	:= dylib
> +else
> +SHLIB_SUFFIX	:= so
> +endif
> +
> +FAKEROOT	:= $(PTXDIST_SYSROOT_HOST)/bin/fakeroot -l $(PTXDIST_SYSROOT_HOST)/lib/libfakeroot.$(SHLIB_SUFFIX)
>  
>  CHECK_PIPE_STATUS := \
>  	for i in  "$${PIPESTATUS[@]}"; do [ $$i -gt 0 ] && {			\
> -- 
> 1.7.7.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de