From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] Fix usage of fakeroot on Darwin
Date: Thu, 19 Jan 2012 20:55:43 +0100 [thread overview]
Message-ID: <20120119195543.GA4854@pengutronix.de> (raw)
In-Reply-To: <1326745825-61103-1-git-send-email-bernhard@bwalle.de>
On Mon, Jan 16, 2012 at 09:30:25PM +0100, Bernhard Walle wrote:
> The extension of shared libraries on Darwin is .dylib, not .so. While
> the fakeroot script itself (which is part of the fakeroot distribution)
> can handle Darwin, ptxdist calls 'fakeroot' with the '-l' parameter and
> directly provides the full path to the shared library which is
> pre-loaded.
Can you try removing '-l <lib>' instead. From looking at the fakeroot
source, it should work. We use it like that in other places already.
Michael
> This patch adds a simple check, explicitly checking for Darwin in the
> 'uname -s' output. Verified to fix the build on Mac OS 10.7 (Lion).
>
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
> rules/pre/Rules.make | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
> index c531a50..32c198b 100644
> --- a/rules/pre/Rules.make
> +++ b/rules/pre/Rules.make
> @@ -13,7 +13,14 @@ GNU_BUILD := $(shell $(SCRIPTSDIR)/autoconf/config.guess)
> GNU_HOST := $(shell echo $(GNU_BUILD) | sed s/-[a-zA-Z0-9_]*-/-host-/)
>
> INSTALL := install
> -FAKEROOT := $(PTXDIST_SYSROOT_HOST)/bin/fakeroot -l $(PTXDIST_SYSROOT_HOST)/lib/libfakeroot.so
> +
> +ifeq ($(shell uname -s),Darwin)
> +SHLIB_SUFFIX := dylib
> +else
> +SHLIB_SUFFIX := so
> +endif
> +
> +FAKEROOT := $(PTXDIST_SYSROOT_HOST)/bin/fakeroot -l $(PTXDIST_SYSROOT_HOST)/lib/libfakeroot.$(SHLIB_SUFFIX)
>
> CHECK_PIPE_STATUS := \
> for i in "$${PIPESTATUS[@]}"; do [ $$i -gt 0 ] && { \
> --
> 1.7.7.4
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-01-19 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 20:30 Bernhard Walle
2012-01-19 19:55 ` Michael Olbrich [this message]
2012-01-19 21:16 ` Bernhard Walle
2012-01-19 21:18 ` Bernhard Walle
2012-01-19 21:24 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119195543.GA4854@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox