From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
From: Juergen Beisert <jbe@pengutronix.de>
Date: Wed, 4 Jan 2012 11:12:49 +0100
References: <201112251856.56188.jbe@pengutronix.de>
	<20120104095551.GD21393@pengutronix.de>
In-Reply-To: <20120104095551.GD21393@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <201201041112.50150.jbe@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] Add the 'kmod' tools and library.
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>

Michael Olbrich wrote:
> [...]
>
> > +config KMOD_ZLIB
> > +	bool
> > +	prompt "use system zlib"
> > +	help
> > +	  Use the system zlib to handle compressed modules
>
> s/system //
>
> otherwise it's not clear that this means on vs. off and not system vs.
> builtin.

Okay.

> [...]
>
> > +KMOD_CONF_TOOL	:= autoconf
> > +KMOD_CONF_OPT	:=
>
> break
>
> $(CROSS_AUTOCONF_USR)  \
>
> > +	--enable-silent-rules \
> >
> > +	--disable-dependency-tracking \
>
> remove

Okay.

> [...]
>
> > +	--disable-static \
> > +	--enable-shared
> > +
> > +ifdef PTXCONF_KMOD_TOOLS
> > +KMOD_CONF_OPT += --enable-tools
> > +else
> > +KMOD_CONF_OPT += --disable-tools
> > +endif
> > +
> > +ifdef PTXCONF_KMOD_DEBUG
> > +KMOD_CONF_OPT += --enable-debug
> > +else
> > +KMOD_CONF_OPT += --disable-debug
> > +endif
> > +
> > +ifdef PTXCONF_KMOD_ZLIB
> > +KMOD_CONF_OPT += --enable-zlib
> > +else
> > +KMOD_CONF_OPT += --disable-zlib
> > +endif
> > +
> > +ifdef PTXCONF_KMOD_LOGGING
> > +KMOD_CONF_OPT += --enable-logging
> > +else
> > +KMOD_CONF_OPT += --disable-logging
> > +endif
>
> please use ptx/endis. It's shorter and you can sort all parameters as
> listed in "configure --help" that makes updates much easier.

Okay. Didn't really noticed this macro yet.

> [...]
>
> > +ifdef PTXCONF_KMOD_TOOLS
> > +	@for file in kmod-insmod kmod-lsmod kmod-modinfo kmod-modprobe kmod-rmmod; \
> > +		do \ 
> > +			$(call install_copy, kmod, 0, 0, 0755, -, /usr/bin/$$file); \
> > +		done
> > +endif
>
> How do these compare to the 'real' tool? While this is nice for testing,
> it would be nice if we could only install these.

They should replace the current used tools in the long term. Main goal for
this package is the library, as it will be used in the future by 'udev'.

> I'd use $(foreach ...) but that's no big issue.

Another macro I'm not a aware off?

Juergen

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de