From: Juergen Beisert <jbe@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] Add the 'kmod' tools and library.
Date: Wed, 4 Jan 2012 11:12:49 +0100 [thread overview]
Message-ID: <201201041112.50150.jbe@pengutronix.de> (raw)
In-Reply-To: <20120104095551.GD21393@pengutronix.de>
Michael Olbrich wrote:
> [...]
>
> > +config KMOD_ZLIB
> > + bool
> > + prompt "use system zlib"
> > + help
> > + Use the system zlib to handle compressed modules
>
> s/system //
>
> otherwise it's not clear that this means on vs. off and not system vs.
> builtin.
Okay.
> [...]
>
> > +KMOD_CONF_TOOL := autoconf
> > +KMOD_CONF_OPT :=
>
> break
>
> $(CROSS_AUTOCONF_USR) \
>
> > + --enable-silent-rules \
> >
> > + --disable-dependency-tracking \
>
> remove
Okay.
> [...]
>
> > + --disable-static \
> > + --enable-shared
> > +
> > +ifdef PTXCONF_KMOD_TOOLS
> > +KMOD_CONF_OPT += --enable-tools
> > +else
> > +KMOD_CONF_OPT += --disable-tools
> > +endif
> > +
> > +ifdef PTXCONF_KMOD_DEBUG
> > +KMOD_CONF_OPT += --enable-debug
> > +else
> > +KMOD_CONF_OPT += --disable-debug
> > +endif
> > +
> > +ifdef PTXCONF_KMOD_ZLIB
> > +KMOD_CONF_OPT += --enable-zlib
> > +else
> > +KMOD_CONF_OPT += --disable-zlib
> > +endif
> > +
> > +ifdef PTXCONF_KMOD_LOGGING
> > +KMOD_CONF_OPT += --enable-logging
> > +else
> > +KMOD_CONF_OPT += --disable-logging
> > +endif
>
> please use ptx/endis. It's shorter and you can sort all parameters as
> listed in "configure --help" that makes updates much easier.
Okay. Didn't really noticed this macro yet.
> [...]
>
> > +ifdef PTXCONF_KMOD_TOOLS
> > + @for file in kmod-insmod kmod-lsmod kmod-modinfo kmod-modprobe kmod-rmmod; \
> > + do \
> > + $(call install_copy, kmod, 0, 0, 0755, -, /usr/bin/$$file); \
> > + done
> > +endif
>
> How do these compare to the 'real' tool? While this is nice for testing,
> it would be nice if we could only install these.
They should replace the current used tools in the long term. Main goal for
this package is the library, as it will be used in the future by 'udev'.
> I'd use $(foreach ...) but that's no big issue.
Another macro I'm not a aware off?
Juergen
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2012-01-04 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-25 17:56 Juergen Beisert
2012-01-04 9:55 ` Michael Olbrich
2012-01-04 10:12 ` Juergen Beisert [this message]
2012-01-04 10:50 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201041112.50150.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox