From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1RiOQi-0002Pr-Q0
	for ptxdist@pengutronix.de; Wed, 04 Jan 2012 11:50:48 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1RiOQi-0007pr-Ov
	for ptxdist@pengutronix.de; Wed, 04 Jan 2012 11:50:48 +0100
Date: Wed, 4 Jan 2012 11:50:48 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20120104105048.GH21393@pengutronix.de>
References: <201112251856.56188.jbe@pengutronix.de>
	<20120104095551.GD21393@pengutronix.de>
	<201201041112.50150.jbe@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <201201041112.50150.jbe@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] Add the 'kmod' tools and library.
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Wed, Jan 04, 2012 at 11:12:49AM +0100, Juergen Beisert wrote:
> Michael Olbrich wrote:
[...]
> > > +ifdef PTXCONF_KMOD_LOGGING
> > > +KMOD_CONF_OPT += --enable-logging
> > > +else
> > > +KMOD_CONF_OPT += --disable-logging
> > > +endif
> >
> > please use ptx/endis. It's shorter and you can sort all parameters as
> > listed in "configure --help" that makes updates much easier.
> 
> Okay. Didn't really noticed this macro yet.

It wasn't really used for a long time, but I think it makes the configure
options much more readable.

> > [...]
> >
> > > +ifdef PTXCONF_KMOD_TOOLS
> > > +	@for file in kmod-insmod kmod-lsmod kmod-modinfo kmod-modprobe kmod-rmmod; \
> > > +		do \ 
> > > +			$(call install_copy, kmod, 0, 0, 0755, -, /usr/bin/$$file); \
> > > +		done
> > > +endif
> >
> > How do these compare to the 'real' tool? While this is nice for testing,
> > it would be nice if we could only install these.
> 
> They should replace the current used tools in the long term. Main goal for
> this package is the library, as it will be used in the future by 'udev'.
> 
> > I'd use $(foreach ...) but that's no big issue.
> 
> Another macro I'm not a aware off?

That's just plain make syntax $(foreach var, list, expression).

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de