From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] Add the 'kmod' tools and library.
Date: Wed, 4 Jan 2012 11:50:48 +0100 [thread overview]
Message-ID: <20120104105048.GH21393@pengutronix.de> (raw)
In-Reply-To: <201201041112.50150.jbe@pengutronix.de>
On Wed, Jan 04, 2012 at 11:12:49AM +0100, Juergen Beisert wrote:
> Michael Olbrich wrote:
[...]
> > > +ifdef PTXCONF_KMOD_LOGGING
> > > +KMOD_CONF_OPT += --enable-logging
> > > +else
> > > +KMOD_CONF_OPT += --disable-logging
> > > +endif
> >
> > please use ptx/endis. It's shorter and you can sort all parameters as
> > listed in "configure --help" that makes updates much easier.
>
> Okay. Didn't really noticed this macro yet.
It wasn't really used for a long time, but I think it makes the configure
options much more readable.
> > [...]
> >
> > > +ifdef PTXCONF_KMOD_TOOLS
> > > + @for file in kmod-insmod kmod-lsmod kmod-modinfo kmod-modprobe kmod-rmmod; \
> > > + do \
> > > + $(call install_copy, kmod, 0, 0, 0755, -, /usr/bin/$$file); \
> > > + done
> > > +endif
> >
> > How do these compare to the 'real' tool? While this is nice for testing,
> > it would be nice if we could only install these.
>
> They should replace the current used tools in the long term. Main goal for
> this package is the library, as it will be used in the future by 'udev'.
>
> > I'd use $(foreach ...) but that's no big issue.
>
> Another macro I'm not a aware off?
That's just plain make syntax $(foreach var, list, expression).
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2012-01-04 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-25 17:56 Juergen Beisert
2012-01-04 9:55 ` Michael Olbrich
2012-01-04 10:12 ` Juergen Beisert
2012-01-04 10:50 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104105048.GH21393@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox