From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1RamtM-00021M-2e
	for ptxdist@pengutronix.de; Wed, 14 Dec 2011 12:20:56 +0100
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1RamtM-0007Gv-1a
	for ptxdist@pengutronix.de; Wed, 14 Dec 2011 12:20:56 +0100
Date: Wed, 14 Dec 2011 12:20:56 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20111214112056.GJ15788@pengutronix.de>
References: <1323817619-69036-1-git-send-email-andreas@biessmann.de>
	<20111214105134.GI15788@pengutronix.de>
	<4EE883AC.7080501@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <4EE883AC.7080501@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] setlocalversion: use /bin/bash explicitly
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Wed, Dec 14, 2011 at 12:08:28PM +0100, Marc Kleine-Budde wrote:
> On 12/14/2011 11:51 AM, Michael Olbrich wrote:
> > On Wed, Dec 14, 2011 at 12:06:59AM +0100, Andreas Bie=DFmann wrote:
> >> Using /bin/sh in setlocalversion lead to corrupted $PTXDIST_VERSION_FU=
LL
> >> cause the 'echo -n "$v"' will use the builtin echo which does not know
> >> about -n switch.
> > =

> > Hmmm, I think we could just drop the '-n'.
> > =

> > Marc: this is your code, what do you think.
> =

> We could use printf instead. I'm not sure what happens, when we have a
> trailing newline in the version information.

It's used in '$()' which should remove the newline.

Michael

-- =

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- =

ptxdist mailing list
ptxdist@pengutronix.de