From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Date: Wed, 14 Dec 2011 11:51:34 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20111214105134.GI15788@pengutronix.de>
References: <1323817619-69036-1-git-send-email-andreas@biessmann.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1323817619-69036-1-git-send-email-andreas@biessmann.de>
Subject: Re: [ptxdist] [PATCH] setlocalversion: use /bin/bash explicitly
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de
Cc: Marc Kleine-Budde <mkl@pengutronix.de>

On Wed, Dec 14, 2011 at 12:06:59AM +0100, Andreas Bie=DFmann wrote:
> Using /bin/sh in setlocalversion lead to corrupted $PTXDIST_VERSION_FULL
> cause the 'echo -n "$v"' will use the builtin echo which does not know
> about -n switch.

Hmmm, I think we could just drop the '-n'.

Marc: this is your code, what do you think.

Michael

> Before this patch my version looks like this:
> =

> ---8<---
> $ ptxdist --version
> -n 2011.12.0-00047-g9849e20
> --->8---
> =

> Signed-off-by: Andreas Bie=DFmann <andreas@biessmann.de>
> ---
>  scripts/kernel/setlocalversion |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> =

> diff --git a/scripts/kernel/setlocalversion b/scripts/kernel/setlocalvers=
ion
> index 3e14135..bf467ea 100755
> --- a/scripts/kernel/setlocalversion
> +++ b/scripts/kernel/setlocalversion
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>  #
>  # This scripts adds local version information from the version
>  # control systems git, mercurial (hg) and subversion (svn).
> -- =

> 1.7.8
> =

> =

> -- =

> ptxdist mailing list
> ptxdist@pengutronix.de

-- =

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- =

ptxdist mailing list
ptxdist@pengutronix.de