mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] setlocalversion: use /bin/bash explicitly
Date: Wed, 14 Dec 2011 11:51:34 +0100	[thread overview]
Message-ID: <20111214105134.GI15788@pengutronix.de> (raw)
In-Reply-To: <1323817619-69036-1-git-send-email-andreas@biessmann.de>

On Wed, Dec 14, 2011 at 12:06:59AM +0100, Andreas Bießmann wrote:
> Using /bin/sh in setlocalversion lead to corrupted $PTXDIST_VERSION_FULL
> cause the 'echo -n "$v"' will use the builtin echo which does not know
> about -n switch.

Hmmm, I think we could just drop the '-n'.

Marc: this is your code, what do you think.

Michael

> Before this patch my version looks like this:
> 
> ---8<---
> $ ptxdist --version
> -n 2011.12.0-00047-g9849e20
> --->8---
> 
> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
> ---
>  scripts/kernel/setlocalversion |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/kernel/setlocalversion b/scripts/kernel/setlocalversion
> index 3e14135..bf467ea 100755
> --- a/scripts/kernel/setlocalversion
> +++ b/scripts/kernel/setlocalversion
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>  #
>  # This scripts adds local version information from the version
>  # control systems git, mercurial (hg) and subversion (svn).
> -- 
> 1.7.8
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2011-12-14 10:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 23:06 Andreas Bießmann
2011-12-14 10:51 ` Michael Olbrich [this message]
2011-12-14 11:08   ` Marc Kleine-Budde
2011-12-14 11:20     ` Michael Olbrich
2011-12-16 18:18 ` [ptxdist] [PATCH v2] setlocalversion: replace echo -n with printf Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111214105134.GI15788@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=mkl@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox