* [ptxdist] ptxdist-2011.11.0 regression on extract
@ 2011-11-22 10:42 Tim Sander
2011-11-22 11:47 ` Michael Olbrich
0 siblings, 1 reply; 5+ messages in thread
From: Tim Sander @ 2011-11-22 10:42 UTC (permalink / raw)
To: ptxdist
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
Hi
I just ran into an error with my own package of host-gchart.
It downloads gchart-2.7.zip and extracts it:
$(call extract, HOST_CHART, $(HOST_GCHART_DIR))
This works without problems in ptxdist-2011.04.1.
With 2011.11.0 the $(HOST_GCHART_DIR) contains the first directory of the
zipfile (javadoc) and not the zipfile root.
Best regards
Tim
[-- Attachment #2: host-gchart.in --]
[-- Type: text/plain, Size: 76 bytes --]
## SECTION=hosttools_noprompt
config HOST_GCHART
tristate
default ALLYES
[-- Attachment #3: host-gchart.make --]
[-- Type: text/plain, Size: 1990 bytes --]
# -*-makefile-*-
#
# Copyright (C) 2011 by Tim Sander <tim.sander@hbm.com>
#
# See CREDITS for details about who has contributed to this project.
#
# For further information about the PTXdist project and license conditions
# see the README file.
#
#
# We provide this package
#
HOST_PACKAGES-$(PTXCONF_HOST_GCHART) += host-gchart
#
# Paths and names
#
HOST_GCHART_VERSION := 2.7
HOST_GCHART := gchart-$(HOST_GCHART_VERSION)
HOST_GCHART_SUFFIX := zip
HOST_GCHART_URL := http://clientsidegchart.googlecode.com/files/$(HOST_GCHART).$(HOST_GCHART_SUFFIX)
HOST_GCHART_SOURCE := $(SRCDIR)/$(HOST_GCHART).$(HOST_GCHART_SUFFIX)
HOST_GCHART_DIR := $(HOST_BUILDDIR)/$(HOST_GCHART)
HOST_GCHART_LICENSE := Apache2.0
# ----------------------------------------------------------------------------
# Get
# ----------------------------------------------------------------------------
$(HOST_GCHART_SOURCE):
@$(call targetinfo)
@$(call get, HOST_GCHART)
# ----------------------------------------------------------------------------
# Prepare
# ----------------------------------------------------------------------------
$(STATEDIR)/host-gchart.prepare:
@$(call targetinfo)
@$(call touch)
# ----------------------------------------------------------------------------
# Extract
# ----------------------------------------------------------------------------
$(STATEDIR)/host-gchart.extract:
@$(call targetinfo)
@$(call clean)
@$(call extract, HOST_GCHART, $(HOST_GCHART_DIR))
@$(call touch)
# ----------------------------------------------------------------------------
# Compile
# ----------------------------------------------------------------------------
$(STATEDIR)/host-gchart.compile:
@$(call targetinfo)
@$(call touch)
# ----------------------------------------------------------------------------
# Install
# ----------------------------------------------------------------------------
$(STATEDIR)/host-gchart.install:
@$(call targetinfo)
@$(call touch)
# vim: syntax=make
[-- Attachment #4: Type: text/plain, Size: 48 bytes --]
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] ptxdist-2011.11.0 regression on extract
2011-11-22 10:42 [ptxdist] ptxdist-2011.11.0 regression on extract Tim Sander
@ 2011-11-22 11:47 ` Michael Olbrich
2011-11-22 12:44 ` Tim Sander
2011-11-22 13:01 ` Tim Sander
0 siblings, 2 replies; 5+ messages in thread
From: Michael Olbrich @ 2011-11-22 11:47 UTC (permalink / raw)
To: ptxdist
On Tue, Nov 22, 2011 at 11:42:59AM +0100, Tim Sander wrote:
> Hi
>
> I just ran into an error with my own package of host-gchart.
>
> It downloads gchart-2.7.zip and extracts it:
> $(call extract, HOST_CHART, $(HOST_GCHART_DIR))
>
> This works without problems in ptxdist-2011.04.1.
>
> With 2011.11.0 the $(HOST_GCHART_DIR) contains the first directory of the
> zipfile (javadoc) and not the zipfile root.
>
> Best regards
> Tim
> ## SECTION=hosttools_noprompt
>
> config HOST_GCHART
> tristate
> default ALLYES
> # -*-makefile-*-
> #
> # Copyright (C) 2011 by Tim Sander <tim.sander@hbm.com>
> #
> # See CREDITS for details about who has contributed to this project.
> #
> # For further information about the PTXdist project and license conditions
> # see the README file.
> #
>
> #
> # We provide this package
> #
> HOST_PACKAGES-$(PTXCONF_HOST_GCHART) += host-gchart
>
> #
> # Paths and names
> #
> HOST_GCHART_VERSION := 2.7
> HOST_GCHART := gchart-$(HOST_GCHART_VERSION)
> HOST_GCHART_SUFFIX := zip
> HOST_GCHART_URL := http://clientsidegchart.googlecode.com/files/$(HOST_GCHART).$(HOST_GCHART_SUFFIX)
> HOST_GCHART_SOURCE := $(SRCDIR)/$(HOST_GCHART).$(HOST_GCHART_SUFFIX)
> HOST_GCHART_DIR := $(HOST_BUILDDIR)/$(HOST_GCHART)
> HOST_GCHART_LICENSE := Apache2.0
HOST_GCHART_STRIP_LEVEL := 0
>
> # ----------------------------------------------------------------------------
> # Get
> # ----------------------------------------------------------------------------
>
> $(HOST_GCHART_SOURCE):
> @$(call targetinfo)
> @$(call get, HOST_GCHART)
>
> # ----------------------------------------------------------------------------
> # Prepare
> # ----------------------------------------------------------------------------
>
> $(STATEDIR)/host-gchart.prepare:
> @$(call targetinfo)
> @$(call touch)
> # ----------------------------------------------------------------------------
> # Extract
> # ----------------------------------------------------------------------------
>
> $(STATEDIR)/host-gchart.extract:
> @$(call targetinfo)
> @$(call clean)
@$(call extract, HOST_GCHART)
or just remove the extract stage.
The change was made, so we can set <PKG>_DIR to something other than what's
inside the archive. Unfortunately the change broke a hand full of packages
like this one.
Michael
> @$(call touch)
>
> # ----------------------------------------------------------------------------
> # Compile
> # ----------------------------------------------------------------------------
>
> $(STATEDIR)/host-gchart.compile:
> @$(call targetinfo)
> @$(call touch)
>
> # ----------------------------------------------------------------------------
> # Install
> # ----------------------------------------------------------------------------
>
> $(STATEDIR)/host-gchart.install:
> @$(call targetinfo)
> @$(call touch)
>
> # vim: syntax=make
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] ptxdist-2011.11.0 regression on extract
2011-11-22 11:47 ` Michael Olbrich
@ 2011-11-22 12:44 ` Tim Sander
2011-11-22 13:01 ` Tim Sander
1 sibling, 0 replies; 5+ messages in thread
From: Tim Sander @ 2011-11-22 12:44 UTC (permalink / raw)
To: ptxdist
Hi
> > HOST_GCHART_VERSION := 2.7
> > HOST_GCHART := gchart-$(HOST_GCHART_VERSION)
> > HOST_GCHART_SUFFIX := zip
> > HOST_GCHART_URL :=
> > http://clientsidegchart.googlecode.com/files/$(HOST_GCHART).$(HOST_GCHAR
> > T_SUFFIX) HOST_GCHART_SOURCE :=
> > $(SRCDIR)/$(HOST_GCHART).$(HOST_GCHART_SUFFIX) HOST_GCHART_DIR :=
> > $(HOST_BUILDDIR)/$(HOST_GCHART)
> > HOST_GCHART_LICENSE := Apache2.0
>
> HOST_GCHART_STRIP_LEVEL := 0
This line made the differnce, thanks. Keeping or leaving the extract stage
didn't make any differnce.
>The change was made, so we can set <PKG>_DIR to something other than what's
>inside the archive. Unfortunately the change broke a hand full of packages
>like this one.
It would have been nice to make the default behaviour the same as before but i
guess thats to late for that now.
Best regards
Tim
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] ptxdist-2011.11.0 regression on extract
2011-11-22 11:47 ` Michael Olbrich
2011-11-22 12:44 ` Tim Sander
@ 2011-11-22 13:01 ` Tim Sander
2011-11-22 13:16 ` Michael Olbrich
1 sibling, 1 reply; 5+ messages in thread
From: Tim Sander @ 2011-11-22 13:01 UTC (permalink / raw)
To: ptxdist
Hi
> > HOST_GCHART_VERSION := 2.7
> > HOST_GCHART := gchart-$(HOST_GCHART_VERSION)
> > HOST_GCHART_SUFFIX := zip
> > HOST_GCHART_URL :=
> > http://clientsidegchart.googlecode.com/files/$(HOST_GCHART).$(HOST_GCHAR
> > T_SUFFIX) HOST_GCHART_SOURCE :=
> > $(SRCDIR)/$(HOST_GCHART).$(HOST_GCHART_SUFFIX) HOST_GCHART_DIR :=
> > $(HOST_BUILDDIR)/$(HOST_GCHART)
> > HOST_GCHART_LICENSE := Apache2.0
>
> HOST_GCHART_STRIP_LEVEL := 0
This line made the differnce, thanks. Keeping or leaving the extract stage
didn't make any differnce.
>The change was made, so we can set <PKG>_DIR to something other than what's
>inside the archive. Unfortunately the change broke a hand full of packages
>like this one.
It would have been nice to make the default behaviour the same as before but i
guess thats to late for that now.
Best regards
Tim
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] ptxdist-2011.11.0 regression on extract
2011-11-22 13:01 ` Tim Sander
@ 2011-11-22 13:16 ` Michael Olbrich
0 siblings, 0 replies; 5+ messages in thread
From: Michael Olbrich @ 2011-11-22 13:16 UTC (permalink / raw)
To: ptxdist
On Tue, Nov 22, 2011 at 02:01:19PM +0100, Tim Sander wrote:
> > > HOST_GCHART_VERSION := 2.7
> > > HOST_GCHART := gchart-$(HOST_GCHART_VERSION)
> > > HOST_GCHART_SUFFIX := zip
> > > HOST_GCHART_URL :=
> > > http://clientsidegchart.googlecode.com/files/$(HOST_GCHART).$(HOST_GCHAR
> > > T_SUFFIX) HOST_GCHART_SOURCE :=
> > > $(SRCDIR)/$(HOST_GCHART).$(HOST_GCHART_SUFFIX) HOST_GCHART_DIR :=
> > > $(HOST_BUILDDIR)/$(HOST_GCHART)
> > > HOST_GCHART_LICENSE := Apache2.0
> >
> > HOST_GCHART_STRIP_LEVEL := 0
> This line made the differnce, thanks. Keeping or leaving the extract stage
> didn't make any differnce.
>
> >The change was made, so we can set <PKG>_DIR to something other than what's
> >inside the archive. Unfortunately the change broke a hand full of packages
> >like this one.
> It would have been nice to make the default behaviour the same as before but i
> guess thats to late for that now.
I tried that. However I couldn't get the _exact_ same behaviour, without
modifying all packages to get the new behaviour. Any extras I tried, only
broke a different set of packages in a more obscure way.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-22 13:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-22 10:42 [ptxdist] ptxdist-2011.11.0 regression on extract Tim Sander
2011-11-22 11:47 ` Michael Olbrich
2011-11-22 12:44 ` Tim Sander
2011-11-22 13:01 ` Tim Sander
2011-11-22 13:16 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox