From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] ptxdist-2011.11.0 regression on extract
Date: Tue, 22 Nov 2011 12:47:48 +0100 [thread overview]
Message-ID: <20111122114748.GH10058@pengutronix.de> (raw)
In-Reply-To: <201111221143.00650.tstone@iss.tu-darmstadt.de>
On Tue, Nov 22, 2011 at 11:42:59AM +0100, Tim Sander wrote:
> Hi
>
> I just ran into an error with my own package of host-gchart.
>
> It downloads gchart-2.7.zip and extracts it:
> $(call extract, HOST_CHART, $(HOST_GCHART_DIR))
>
> This works without problems in ptxdist-2011.04.1.
>
> With 2011.11.0 the $(HOST_GCHART_DIR) contains the first directory of the
> zipfile (javadoc) and not the zipfile root.
>
> Best regards
> Tim
> ## SECTION=hosttools_noprompt
>
> config HOST_GCHART
> tristate
> default ALLYES
> # -*-makefile-*-
> #
> # Copyright (C) 2011 by Tim Sander <tim.sander@hbm.com>
> #
> # See CREDITS for details about who has contributed to this project.
> #
> # For further information about the PTXdist project and license conditions
> # see the README file.
> #
>
> #
> # We provide this package
> #
> HOST_PACKAGES-$(PTXCONF_HOST_GCHART) += host-gchart
>
> #
> # Paths and names
> #
> HOST_GCHART_VERSION := 2.7
> HOST_GCHART := gchart-$(HOST_GCHART_VERSION)
> HOST_GCHART_SUFFIX := zip
> HOST_GCHART_URL := http://clientsidegchart.googlecode.com/files/$(HOST_GCHART).$(HOST_GCHART_SUFFIX)
> HOST_GCHART_SOURCE := $(SRCDIR)/$(HOST_GCHART).$(HOST_GCHART_SUFFIX)
> HOST_GCHART_DIR := $(HOST_BUILDDIR)/$(HOST_GCHART)
> HOST_GCHART_LICENSE := Apache2.0
HOST_GCHART_STRIP_LEVEL := 0
>
> # ----------------------------------------------------------------------------
> # Get
> # ----------------------------------------------------------------------------
>
> $(HOST_GCHART_SOURCE):
> @$(call targetinfo)
> @$(call get, HOST_GCHART)
>
> # ----------------------------------------------------------------------------
> # Prepare
> # ----------------------------------------------------------------------------
>
> $(STATEDIR)/host-gchart.prepare:
> @$(call targetinfo)
> @$(call touch)
> # ----------------------------------------------------------------------------
> # Extract
> # ----------------------------------------------------------------------------
>
> $(STATEDIR)/host-gchart.extract:
> @$(call targetinfo)
> @$(call clean)
@$(call extract, HOST_GCHART)
or just remove the extract stage.
The change was made, so we can set <PKG>_DIR to something other than what's
inside the archive. Unfortunately the change broke a hand full of packages
like this one.
Michael
> @$(call touch)
>
> # ----------------------------------------------------------------------------
> # Compile
> # ----------------------------------------------------------------------------
>
> $(STATEDIR)/host-gchart.compile:
> @$(call targetinfo)
> @$(call touch)
>
> # ----------------------------------------------------------------------------
> # Install
> # ----------------------------------------------------------------------------
>
> $(STATEDIR)/host-gchart.install:
> @$(call targetinfo)
> @$(call touch)
>
> # vim: syntax=make
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2011-11-22 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 10:42 Tim Sander
2011-11-22 11:47 ` Michael Olbrich [this message]
2011-11-22 12:44 ` Tim Sander
2011-11-22 13:01 ` Tim Sander
2011-11-22 13:16 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122114748.GH10058@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox