From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] $(KERNEL_PATH)/vmlinux should not depend on kernel.targetinstall
Date: Sun, 13 Nov 2011 10:48:32 +0100 [thread overview]
Message-ID: <20111113094832.GC9073@pengutronix.de> (raw)
In-Reply-To: <1320851812-5969-1-git-send-email-alexander.stein@systec-electronic.com>
On Wed, Nov 09, 2011 at 04:16:52PM +0100, Alexander Stein wrote:
> If PTXCONF_KERNEL_IMAGE_VMLINUX is set, KERNEL_IMAGE_PATH_y is set to
> $(KERNEL_PATH)/vmlinux. This should not depend on kernel.targetinstall
> because kernel.targetinstall will be newer than vmlinux and make tries
> to recreate vmlinux and implicit removes the target file.
This is a problem for all PTXCONF_KERNEL_IMAGE_* not just VMLINUX.
Maybe:
----------------------------------------------------------------------
+ifeq ($(wildcard $(KERNEL_IMAGE_PATH_y)),)
$(KERNEL_IMAGE_PATH_y): $(STATEDIR)/kernel.targetinstall
+endif
----------------------------------------------------------------------
Or completely remove KERNEL_IMAGE_PATH_y from the dependency chain:
----------------------------------------------------------------------
$(KERNEL_MAKEVARS) $(KERNEL_IMAGE)
@echo "done."
-$(KERNEL_IMAGE_PATH_y): $(STATEDIR)/kernel.targetinstall
-
-$(IMAGEDIR)/linuximage: $(KERNEL_IMAGE_PATH_y)
+$(IMAGEDIR)/linuximage: $(STATEDIR)/kernel.targetinstall
@echo -n "Creating '$(notdir $(@))' from '$(notdir $(<))'..."
@install -m 644 "$(<)" "$(@)"
@echo "done."
----------------------------------------------------------------------
Marc: you introduced the original dependency. Can you see a case where this
won't work?
Michael
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> rules/post/image_kernel.make | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/rules/post/image_kernel.make b/rules/post/image_kernel.make
> index 7ffeed6..6f1defe 100644
> --- a/rules/post/image_kernel.make
> +++ b/rules/post/image_kernel.make
> @@ -23,7 +23,9 @@ $(STATEDIR)/image_kernel.compile: $(IMAGEDIR)/root.cpio
> $(KERNEL_MAKEVARS) $(KERNEL_IMAGE)
> @echo "done."
>
> +ifndef PTXCONF_KERNEL_IMAGE_VMLINUX
> $(KERNEL_IMAGE_PATH_y): $(STATEDIR)/kernel.targetinstall
> +endif
>
> $(IMAGEDIR)/linuximage: $(KERNEL_IMAGE_PATH_y)
> @echo -n "Creating '$(notdir $(@))' from '$(notdir $(<))'..."
> --
> 1.7.3.4
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2011-11-13 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 15:16 Alexander Stein
2011-11-13 9:48 ` Michael Olbrich [this message]
2012-01-26 9:57 ` Alexander Stein
2012-01-26 15:47 ` [ptxdist] [PATCH] linuximage: cleanup dependencies Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111113094832.GC9073@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=mkl@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox