mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] alsa-lib: Allow installation of /etc/asound.conf
Date: Tue, 8 Nov 2011 15:36:30 +0100	[thread overview]
Message-ID: <20111108143630.GA7920@regiomontanus.bwalle.de> (raw)
In-Reply-To: <201111081529.26688.jbe@pengutronix.de>

* Juergen Beisert <jbe@pengutronix.de> [2011-11-08 15:29]:
> bernhard@bwalle.de wrote:
> > [...]
> > diff --git a/rules/alsa-lib.make b/rules/alsa-lib.make
> > index 929ab4e..bfec83f 100644
> > --- a/rules/alsa-lib.make
> > +++ b/rules/alsa-lib.make
> > @@ -207,6 +207,12 @@ endif
> >  		/usr/share/alsa/pcm/dsnoop.conf)
> >  endif
> >
> > +ifdef PTXCONF_ALSA_LIB_ASOUND_CONF
> > +	@$(call install_copy, alsa-lib, 0, 0, 0644, \
> > +		$(PTXDIST_WORKSPACE)/projectroot/etc/asound.conf, \
> > +		/etc/asound.conf)
> > +endif
> > +
> 
> You should use the 'install_alternative' macro here. It's more flexible and 
> you also can store this special file in the platform instead of the BSP 
> project (as this file is more related to the platform than the BSP).

Ah, yes, sorry. It's still from my first steps with ptxdist and after
the latest ALSA update I had to adjust my copied alsa-lib.*, so I
thought it's better to send it mainline. Unfortunately, I didn't take a
closer look ...

Updated patch will follow.


Regards,
Bernhard

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2011-11-08 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 14:17 bernhard
2011-11-08 14:29 ` Juergen Beisert
2011-11-08 14:36   ` Bernhard Walle [this message]
2011-11-08 15:21   ` bernhard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111108143630.GA7920@regiomontanus.bwalle.de \
    --to=bernhard@bwalle.de \
    --cc=jbe@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox