From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mediacenter.hi.pengutronix.de ([2001:6f8:1178:2::65])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1RJRbf-000476-NP
	for ptxdist@pengutronix.de; Thu, 27 Oct 2011 17:10:59 +0200
Received: from mol by mediacenter.hi.pengutronix.de with local (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1RJRbf-0001HF-Ma
	for ptxdist@pengutronix.de; Thu, 27 Oct 2011 17:10:59 +0200
Date: Thu, 27 Oct 2011 17:10:59 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20111027151059.GF30634@pengutronix.de>
References: <1319226812-41219-1-git-send-email-andreas@biessmann.de>
	<1319226812-41219-3-git-send-email-andreas@biessmann.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1319226812-41219-3-git-send-email-andreas@biessmann.de>
Subject: Re: [ptxdist] [PATCH 2/5] configure.ac: add check for chmod from
 GNU coreutils
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Fri, Oct 21, 2011 at 09:53:29PM +0200, Andreas Bie=DFmann wrote:
> Signed-off-by: Andreas Bie=DFmann <andreas@biessmann.de>
> ---
>  Makefile.in  |    1 +
>  configure.ac |    9 +++++++++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> =

> diff --git a/Makefile.in b/Makefile.in
> index 62fabf6..eb775de 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -78,6 +78,7 @@ install-environment: all dirty-check
>  	@mkdir -p "$(DESTDIR)$(instdir)"
>  	@mkdir -p $(DESTDIR)$(instdir)/bin
>  	@ln -sf @SED@ $(DESTDIR)$(instdir)/bin/sed
> +	@ln -sf @GNUCHMOD@ $(DESTDIR)$(instdir)/bin/chmod
>  =

>  dist: dirty-check
>  	@rm -rf "$(project)"
> diff --git a/configure.ac b/configure.ac
> index 7a34e7a..e155403 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -133,6 +133,15 @@ case "$SED_VERSION" in
>  esac
>  AC_MSG_RESULT([$SED_VERSION])
>  =

> +dnl check for chmod GNU version
> +AC_CACHE_CHECK([for chmod from GNU coreutils], [ac_cv_path_GNUCHMOD],
> +               [AC_PATH_PROGS_FEATURE_CHECK([GNUCHMOD], [chmod gchmod],
> +                                            [[gnuchmodout=3D`$ac_path_GN=
UCHMOD --version 2>/dev/null | $SED -ne "s/.*\(GNU\) coreutils.*/\1/p"`
> +                                             test "x$gnuchmodout" =3D xG=
NU \
> +                                                 && ac_cv_path_GNUCHMOD=
=3D$ac_path_GNUCHMOD ac_path_GNUCHMOD_found=3D:]],
> +                                             [AC_MSG_ERROR([could not fi=
nd chmod from GNU coreutils])])])
> +AC_SUBST([GNUCHMOD], [$ac_cv_path_GNUCHMOD])

I like the patches in general, but I'm not certain about restricting it to
GNU coreutils. Are we using GNU extensions for all these tools? If yes I'd
like so see a macro for this so we can just add:

PTX_PATH_GNU_COREUTIL(chmod)

or whatever the correct name for such a macro would be.

Michael

> +
>  dnl Check for egrep
>  AC_PROG_EGREP
>  =

> -- =

> 1.7.7
> =

> =

> -- =

> ptxdist mailing list
> ptxdist@pengutronix.de

-- =

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- =

ptxdist mailing list
ptxdist@pengutronix.de