Re: [ptxdist] [PATCH 2/5] configure.ac: add check for chmod from GNU coreutils

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Oct 21, 2011 at 09:53:29PM +0200, Andreas Bießmann wrote:
> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
> ---
>  Makefile.in  |    1 +
>  configure.ac |    9 +++++++++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile.in b/Makefile.in
> index 62fabf6..eb775de 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -78,6 +78,7 @@ install-environment: all dirty-check
>  	@mkdir -p "$(DESTDIR)$(instdir)"
>  	@mkdir -p $(DESTDIR)$(instdir)/bin
>  	@ln -sf @SED@ $(DESTDIR)$(instdir)/bin/sed
> +	@ln -sf @GNUCHMOD@ $(DESTDIR)$(instdir)/bin/chmod
>  
>  dist: dirty-check
>  	@rm -rf "$(project)"
> diff --git a/configure.ac b/configure.ac
> index 7a34e7a..e155403 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -133,6 +133,15 @@ case "$SED_VERSION" in
>  esac
>  AC_MSG_RESULT([$SED_VERSION])
>  
> +dnl check for chmod GNU version
> +AC_CACHE_CHECK([for chmod from GNU coreutils], [ac_cv_path_GNUCHMOD],
> +               [AC_PATH_PROGS_FEATURE_CHECK([GNUCHMOD], [chmod gchmod],
> +                                            [[gnuchmodout=`$ac_path_GNUCHMOD --version 2>/dev/null | $SED -ne "s/.*\(GNU\) coreutils.*/\1/p"`
> +                                             test "x$gnuchmodout" = xGNU \
> +                                                 && ac_cv_path_GNUCHMOD=$ac_path_GNUCHMOD ac_path_GNUCHMOD_found=:]],
> +                                             [AC_MSG_ERROR([could not find chmod from GNU coreutils])])])
> +AC_SUBST([GNUCHMOD], [$ac_cv_path_GNUCHMOD])

I like the patches in general, but I'm not certain about restricting it to
GNU coreutils. Are we using GNU extensions for all these tools? If yes I'd
like so see a macro for this so we can just add:

PTX_PATH_GNU_COREUTIL(chmod)

or whatever the correct name for such a macro would be.

Michael

> +
>  dnl Check for egrep
>  AC_PROG_EGREP
>  
> -- 
> 1.7.7
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de