From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from octopus.hi.pengutronix.de ([2001:6f8:1178:2:215:17ff:fe12:23b0]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1RGaDh-0002Ie-0h for ptxdist@pengutronix.de; Wed, 19 Oct 2011 19:46:25 +0200 Received: from rsc by octopus.hi.pengutronix.de with local (Exim 4.76) (envelope-from ) id 1RGaDg-0001OI-VT for ptxdist@pengutronix.de; Wed, 19 Oct 2011 19:46:24 +0200 Date: Wed, 19 Oct 2011 19:46:24 +0200 From: Robert Schwebel Message-ID: <20111019174624.GN7130@pengutronix.de> References: <1318893704-23961-1-git-send-email-jon@ringle.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] [PATCH] ptxd_ipkg_rev_smaller: fix compare with empty micro Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Tue, Oct 18, 2011 at 04:42:46AM -0400, Jon Ringle wrote: > After more testing, I found that there were other situations where the ve= rsion > comparison does not work well. > = > I ended up replacing the implementation of ptxd_ipkg_rev_smaller() with > something much simpler, albeit dependent on dpkg that seems to work well: > = > ptxd_ipkg_rev_smaller() { > =A0 =A0 dpkg --compare-versions $1 lt $2 > } Hmm, that makes us dependend on dpkg (and thus on Debian). PTXdist tries hard to run on any distribution, so I'm not happy with this. rsc -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = ptxdist mailing list ptxdist@pengutronix.de