From: Robert Schwebel <r.schwebel@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ptxd_ipkg_rev_smaller: fix compare with empty micro
Date: Wed, 19 Oct 2011 19:46:24 +0200 [thread overview]
Message-ID: <20111019174624.GN7130@pengutronix.de> (raw)
In-Reply-To: <CAMwGMjwRFb17Z4kZOi+13ucnjjWKE8fmebPTgSxVXPVorxk=Mg@mail.gmail.com>
On Tue, Oct 18, 2011 at 04:42:46AM -0400, Jon Ringle wrote:
> After more testing, I found that there were other situations where the version
> comparison does not work well.
>
> I ended up replacing the implementation of ptxd_ipkg_rev_smaller() with
> something much simpler, albeit dependent on dpkg that seems to work well:
>
> ptxd_ipkg_rev_smaller() {
> dpkg --compare-versions $1 lt $2
> }
Hmm, that makes us dependend on dpkg (and thus on Debian). PTXdist tries
hard to run on any distribution, so I'm not happy with this.
rsc
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2011-10-19 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 23:21 Jon Ringle
2011-10-18 8:42 ` Jon Ringle
2011-10-19 17:46 ` Robert Schwebel [this message]
2011-10-19 18:52 ` Bernhard Walle
2011-10-19 19:55 ` Jon Ringle
2011-10-20 6:10 ` Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019174624.GN7130@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox