Re: [ptxdist] [PATCH] libptxdist: explicitly use sed to run migrate_*

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Oct 17, 2011 at 12:45:26PM +0200, Bernhard Walle wrote:
> * Andreas Bießmann <andreas@biessmann.de> [2011-10-17 09:06]:
> > 
> > >It's not really nice, but I think it's better than patching lots of
> > >tools. And having scripts as executable programs is IMO still better
> > >than having to call the interpreter manually (which is necessary with
> > >your $PTXDIST_SED approach.
> > 
> > But how should we handle a script's sheebang? If we require the
> > scripts/migrate tools to be executable scripts we need to preprocess
> > the scripts to adopt the sheebang to e.g. $PTXDIST_BINDIR. I think
> > it is much more portable to have the shell scripts kall the
> > interpreter with the respective configuration, e.g.
> > $PTXDIST_BINDIR/sed -f scripts/migrate/migrate_platform.
> 
> sed is the only exception I know that requires an argument.
> #!/usr/bin/env perl, #!/usr/bin/env python, #!/usr/bin/env ruby works.

Well, awk as well, but as long as it's in ptxdist itself, that's not a
problem. We can call the program directly and let the shell do the rest.
I'm more concerned about scripts called in various packages. And sed and
awk are rarely called via a shebang.

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de